Closed Bug 1216473 Opened 9 years ago Closed 6 years ago

[Aries] Mifare Classic is not fully supported in Aries, reading this kind of tag could disable RF occasionally

Categories

(Firefox OS Graveyard :: NFC, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED WONTFIX

People

(Reporter: tnguyen, Unassigned)

References

Details

Mifare Classic is not fully supported in Aries, reading this kind of tag could disable RF occasionally 
After scanning this tag, RF will be disabled and could not scan next NFC tag
Depends on: 1136512
Assignee: nobody → tnguyen
Can you provide more informations on that ? I guess you want to fix bug 1136512 because of this one, but it really lacks informations like logs, STRs, etc.

Did you already locally tested that for fixing reading Mifare Classic? Where can I find those tags to test? Do we have extensively tested the impact of that change on the rest of the device? Changing from a blob to source-built code is fine but we are quite late in the cycle right now and I want to make sure we do not regress anything else also.

How urgent is that? 2.5+ ?
Flags: needinfo?(tnguyen)
(In reply to Alexandre LISSY :gerard-majax from comment #1)
> Can you provide more informations on that ? I guess you want to fix bug
> 1136512 because of this one, but it really lacks informations like logs,
> STRs, etc.
> 
> Did you already locally tested that for fixing reading Mifare Classic? Where
> can I find those tags to test? Do we have extensively tested the impact of
> that change on the rest of the device? Changing from a blob to source-built
> code is fine but we are quite late in the cycle right now and I want to make
> sure we do not regress anything else also.
> 
> How urgent is that? 2.5+ ?

Since Thomas is on PTO now, I will answer this for him.

This bug doesn't exist on current Aries build, it will only happen when we follow the instruction of Bug 1136512 Comment 6. If i remembered correctly, Thomas has already found patch to fix this issue.
So he just separates the bug to make patch fix more clearly.
Flags: needinfo?(tnguyen)
Then it's unclear: why do we need to fix bug 1136512, except for killing a blob?
Flags: needinfo?(dlee)
(In reply to Alexandre LISSY :gerard-majax from comment #3)
> Then it's unclear: why do we need to fix bug 1136512, except for killing a
> blob?
NFC payment doesn't work on Aries now (Bug 1201427). The root cause is described in Bug 1136512 Comment 4.
Flags: needinfo?(dlee)
(In reply to Dimi Lee[:dimi][:dlee] from comment #4)
> (In reply to Alexandre LISSY :gerard-majax from comment #3)
> > Then it's unclear: why do we need to fix bug 1136512, except for killing a
> > blob?
> NFC payment doesn't work on Aries now (Bug 1201427). The root cause is
> described in Bug 1136512 Comment 4.

Does it works on Android KK on the same device?
Flags: needinfo?(dlee)
(In reply to Dimi Lee[:dimi][:dlee] from comment #2)
> (In reply to Alexandre LISSY :gerard-majax from comment #1)
> > Can you provide more informations on that ? I guess you want to fix bug
> > 1136512 because of this one, but it really lacks informations like logs,
> > STRs, etc.
> > 
> > Did you already locally tested that for fixing reading Mifare Classic? Where
> > can I find those tags to test? Do we have extensively tested the impact of
> > that change on the rest of the device? Changing from a blob to source-built
> > code is fine but we are quite late in the cycle right now and I want to make
> > sure we do not regress anything else also.
> > 
> > How urgent is that? 2.5+ ?
> 
> Since Thomas is on PTO now, I will answer this for him.
> 
> This bug doesn't exist on current Aries build, it will only happen when we
> follow the instruction of Bug 1136512 Comment 6.

I am lost: you say the bug does not exists currently, and then you refer to bug 1201427 where it is explained that this is currently not working :(
Sorry I didn't explain this clearly. Let me try to explain more detail.

1.In current build on AriesKK, QA found that NFC payment doesn't work - Bug 1201427

2.We found that the root cause of NFC payment doesn't work is because of the header files used by nfcd is not sync with the library files on the device. And this is exactly what we are trying to fix in Bug 1136512, so we set payment bug as a duplicate bug.

3.Locally fix Bug 1136512 according to Bug 1136512 Comment 6 and check if all NFC features are working fine after the fix. We found reading Mifare-Classic tag is not working, so create this bug as a follow-up bug of Bug 1136512(Thomas has a working patch for this bug).

Please let me know if there is anything unclear to you :)
Flags: needinfo?(dlee)
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → DUPLICATE
As suggested in bug 1136512, reopen this bug
Status: RESOLVED → REOPENED
Resolution: DUPLICATE → ---
Assignee: tnguyen → nobody
Firefox OS is not being worked on
Status: REOPENED → RESOLVED
Closed: 9 years ago6 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.