Closed Bug 1216495 Opened 9 years ago Closed 9 years ago

Change audio channel type of the click sound from "normal" to "system"

Categories

(Firefox OS Graveyard :: Gaia::Keyboard, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::Keyboard
Platform:
ARM
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(b2g-master verified)

Status:
VERIFIED FIXED
Tracking Flags:
Tracking Status
b2g-master --- verified

People

(Reporter: alwu, Assigned: evanxd)

References

Details

Attachments

(1 file)

[gaia] evanxd:bug-1216495 > mozilla-b2g:master
46 bytes, text/x-github-pull-request
timdream
: review+
Details | Review
From UX sound spec [1], The click sound of the built-in keyboard should use the "system" audio channel type. [1] https://bug1068219.bmoattachments.org/attachment.cgi?id=8579177#12
I have already written a patch, but got the strange error - "Error - Cannot find module babel-eslint". Need to find out why.
Because my github have some problem, Evan will help with this issue.
Assignee: alwu → evan
Comment on attachment 8676674 [details] [review] [gaia] evanxd:bug-1216495 > mozilla-b2g:master Hi Tim, Could you review the patch? Thanks.
Attachment #8676674 - Flags: review?(timdream)
Comment on attachment 8676674 [details] [review] [gaia] evanxd:bug-1216495 > mozilla-b2g:master Thanks!
Attachment #8676674 - Flags: review?(timdream) → review+
Tim, thanks for the review.
master: https://github.com/mozilla-b2g/gaia/commit/4faf8088acaa8c875e34c53f397bfb46128cbb50
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
This issue is verified fixed on the latest Flame and Aries 2.5 Master build. Keyboard click sounds are audible, and play properly. Environmental Variables: Device: Aries 2.5 BuildID: 20151026111709 Gaia: a677ddd3aa3a81058775938bd56008d96dbc78b0 Gecko: 5ca03a00d26823ce91ee0eaa2937bed605bd53c1 Gonk: 2916e2368074b5383c80bf5a0fba3fc83ba310bd Version: 44.0a1 (2.5) Firmware Version: D5803_23.1.A.1.28_NCB.ftf User Agent: Mozilla/5.0 (Mobile; rv:44.0) Gecko/44.0 Firefox/44.0 Environmental Variables: Device: Flame 2.5 BuildID: 20151026030217 Gaia: a677ddd3aa3a81058775938bd56008d96dbc78b0 Gecko: 5ca03a00d26823ce91ee0eaa2937bed605bd53c1 Gonk: 205ac4204bbbb2098a8046444acba551ba5dc75a Version: 44.0a1 (2.5) Firmware Version: v18D User Agent: Mozilla/5.0 (Mobile; rv:44.0) Gecko/44.0 Firefox/44.0
Status: RESOLVED → VERIFIED
QA Whiteboard: [QAnalyst-Triage?]
status-b2g-master: --- → verified
Flags: needinfo?(jmercado)
QA Whiteboard: [QAnalyst-Triage?] → [QAnalyst-Triage+]
Flags: needinfo?(jmercado)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: