1216520 - Comma key has gone missing

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System::Input Mgmt, defect)

Description

[Chris Lord [:cwiiis]]

[Blocking Requested - why for this release]: Annoying regression in a very visible and commonly-used system component

My comma key has gone missing, replaced by a language-selector key. Tapping this key does nothing, long-pressing it gives me a pop-up with just one option that's already selected (so, practically, does nothing except waste time).

Meanwhile, I'm missing a very commonly used key. It's still available in the symbols section and under the long-press punctuation key, but both of these are very awkward vs. just pressing a key on the primary keyboard.

Comment 1

[Mahendra Potharaju [:mahe]]

UX Team, Can you please confirm the location of comma.

Comment 2

[Tim Guan-tin Chien [:timdream] (please needinfo)]

This is the behavior described in the spec in bug 983043.

Un-non because it's a new feature if we decided to change the feature spec base on this user feedback.

Comment 3

[Chris Lord [:cwiiis]]

(In reply to Tim Guan-tin Chien [:timdream] (please needinfo) from comment #2)
> This is the behavior described in the spec in bug 983043.
> 
> Un-non because it's a new feature if we decided to change the feature spec
> base on this user feedback.

Who do I talk to to express my opinion on this? The comma, a frequently-used, useful key has been swapped for a key that literally does nothing for me. Well, not quite literally, it does waste some time, but otherwise has no effect...

Comment 4

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Tori, could you provide some comment as keyboard UX?

Comment 5

[Tiffanie Shakespeare [:tif]]

Removing NI for UX team as Tori has been flagged.

Comment 6

[Mahendra Potharaju [:mahe]]

I agree with Chris. In my opinion Comma is a frequent need than language selection.

Comment 7

[Tori Chen [:tori]]

If we keep current layout and put Comma and language-selector on keyboard at the same time, the backspace will be cut to a not-user-friendly size. This may need to resize other keys and UX/Visual would need some time to study on this.

Comment 8

[Tim Guan-tin Chien [:timdream] (please needinfo)]

I am very sorry -- this is actually an regression on my part. The spec asks the language switch key to show up (and replace the comma key) whenever there is one or more layout enabled, but the regression have cause it to always shown and the comma key is never shown.

I thought the question was whether or not to also keep the comma key even if the language switch key is shown.

Comment 9

[GitHub Autolander Bot]

Attachment: [gaia] timdream:input-mgmt-setSupportsSwitchingTypes > mozilla-b2g:master

Comment 10

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Comment on attachment 8682315 [details] [review]
[gaia] timdream:input-mgmt-setSupportsSwitchingTypes > mozilla-b2g:master

Alberto, could you review this small logical error :'( Thanks.

Comment 11

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Correction to comment 8:

The spec asks the language switch key to show up (and replace the comma key) whenever there is _more than two layout enabled_, but the regression have cause it to always shown and the comma key is always hidden.

I thought the question was whether or not to also keep the comma key even if the language switch key is shown.

Comment 12

[Alberto Pastor [:albertopq]]

Comment on attachment 8682315 [details] [review]
[gaia] timdream:input-mgmt-setSupportsSwitchingTypes > mozilla-b2g:master

Left a comment, but LGTM. Make sure all tests are green before landing (GU17 is failing, although I don't think is because of the patch)

Comment 13

[Tim Guan-tin Chien [:timdream] (please needinfo)]

master: https://github.com/mozilla-b2g/gaia/commit/e7ea77a80e8fa885d969f10a809ed2d479d3dd64

Comment 14

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Comment on attachment 8682315 [details] [review]
[gaia] timdream:input-mgmt-setSupportsSwitchingTypes > mozilla-b2g:master

[Approval Request Comment]
[Bug caused by] : bug 1200142
[User impact] if declined: A useless switch layout key will replace comma key on the keyboard for user only enables one layout
[Testing completed]: with unit test and manually
[Risk to taking this patch] (and alternatives if risky): the patch fixed a logical error located in one function. The risk is low since additional unit test is added to assert the logic.
[String changes made]: none.

Comment 15

[Mahendra Potharaju [:mahe]]

Comment on attachment 8682315 [details] [review]
[gaia] timdream:input-mgmt-setSupportsSwitchingTypes > mozilla-b2g:master

This landed in 2.5. Updating approval flag

Thanks

Comment 16

[Carsten Book [:Tomcat]]

on 2.5 -> https://hg.mozilla.org/integration/gaia-2_5/rev/9e506a8f91ad