Dismantle last bits of app-manager into WebIDE

RESOLVED FIXED in Firefox 45, Firefox OS v2.5

Status

RESOLVED FIXED
3 years ago
3 months ago

People

(Reporter: ochameau, Assigned: ochameau)

Tracking

unspecified
Firefox 45

Firefox Tracking Flags

(firefox45 fixed, b2g-v2.5 fixed)

Details

Attachments

(1 attachment, 3 obsolete attachments)

(Assignee)

Description

3 years ago
Once bug 1007061 lands, there will still be some resource in /devtools/app-manager/, files being still used by WebIDE.
We should integrate them into WebIDE folders or get rid of these deps.
(Assignee)

Comment 1

3 years ago
Created attachment 8677603 [details] [diff] [review]
Merge last bits of app-manager into WebIDE.
(Assignee)

Comment 3

3 years ago
Created attachment 8678990 [details] [diff] [review]
patch v2

Also includes some require(Services) / require(promise) cleanups
as well as some removal of app-manager references.
(that are not about the webide/modules/app-manager module!)

I also tried to clean bugzilla from some app-manager bugs/references.
(Assignee)

Updated

3 years ago
Attachment #8677603 - Attachment is obsolete: true
(Assignee)

Updated

3 years ago
Assignee: nobody → poirot.alex
(Assignee)

Comment 6

3 years ago
Created attachment 8680711 [details] [diff] [review]
patch v3

Last time you are going to hear about the app manager ;-)

Wait?! No, there is this the webide module!!
Attachment #8680711 - Flags: review?(jryans)
(Assignee)

Updated

3 years ago
Attachment #8678990 - Attachment is obsolete: true
Comment on attachment 8680711 [details] [diff] [review]
patch v3

Review of attachment 8680711 [details] [diff] [review]:
-----------------------------------------------------------------

Great work! :D

::: browser/locales/jar.mn
@@ +77,5 @@
>      locale/browser/devtools/connection-screen.dtd  (%chrome/browser/devtools/connection-screen.dtd)
>      locale/browser/devtools/connection-screen.properties (%chrome/browser/devtools/connection-screen.properties)
>      locale/browser/devtools/font-inspector.dtd     (%chrome/browser/devtools/font-inspector.dtd)
>      locale/browser/devtools/har.properties         (%chrome/browser/devtools/har.properties)
> +    locale/browser/devtools/app-validator.properties (%chrome/browser/devtools/app-validator.properties)

I believe this will cause all the strings to be re-translated... not sure it's worth it?  On the other hand, it's probably left untranslated in many locales.  I leave it up to you.
Attachment #8680711 - Flags: review?(jryans) → review+
(Assignee)

Comment 8

3 years ago
Created attachment 8681885 [details] [diff] [review]
patch v4

Do not rename app-manager.properties.
Attachment #8681885 - Flags: review+
(Assignee)

Updated

3 years ago
Attachment #8680711 - Attachment is obsolete: true

Comment 10

3 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/a8cc3e63866f
Status: NEW → RESOLVED
Last Resolved: 3 years ago
status-firefox45: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 45

Updated

3 months ago
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.