Once bug 1007061 lands, there will still be some resource in /devtools/app-manager/, files being still used by WebIDE. We should integrate them into WebIDE folders or get rid of these deps.
Created attachment 8678990 [details] [diff] [review] patch v2 Also includes some require(Services) / require(promise) cleanups as well as some removal of app-manager references. (that are not about the webide/modules/app-manager module!) I also tried to clean bugzilla from some app-manager bugs/references.
Attachment #8677603 - Attachment is obsolete: true
Created attachment 8680711 [details] [diff] [review] patch v3 Last time you are going to hear about the app manager ;-) Wait?! No, there is this the webide module!!
Attachment #8680711 - Flags: review?(jryans)
Attachment #8678990 - Attachment is obsolete: true
Comment on attachment 8680711 [details] [diff] [review] patch v3 Review of attachment 8680711 [details] [diff] [review]: ----------------------------------------------------------------- Great work! :D ::: browser/locales/jar.mn @@ +77,5 @@ > locale/browser/devtools/connection-screen.dtd (%chrome/browser/devtools/connection-screen.dtd) > locale/browser/devtools/connection-screen.properties (%chrome/browser/devtools/connection-screen.properties) > locale/browser/devtools/font-inspector.dtd (%chrome/browser/devtools/font-inspector.dtd) > locale/browser/devtools/har.properties (%chrome/browser/devtools/har.properties) > + locale/browser/devtools/app-validator.properties (%chrome/browser/devtools/app-validator.properties) I believe this will cause all the strings to be re-translated... not sure it's worth it? On the other hand, it's probably left untranslated in many locales. I leave it up to you.
Attachment #8680711 - Flags: review?(jryans) → review+
Created attachment 8681885 [details] [diff] [review] patch v4 Do not rename app-manager.properties.
Attachment #8681885 - Flags: review+
Attachment #8680711 - Attachment is obsolete: true
https://hg.mozilla.org/integration/fx-team/rev/a8cc3e63866f20e70104c6b426ea93463a0e02cb Bug 1216590 - Merge last bits of app-manager into WebIDE. r=jryans
Status: NEW → RESOLVED
Last Resolved: 3 years ago
status-firefox45: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 45
status-b2g-v2.5: --- → fixed
You need to log in before you can comment on or make changes to this bug.