Closed Bug 1216590 Opened 7 years ago Closed 7 years ago

Dismantle last bits of app-manager into WebIDE


(DevTools Graveyard :: WebIDE, defect)

Not set


(firefox45 fixed, b2g-v2.5 fixed)

Firefox 45
Tracking Status
firefox45 --- fixed
b2g-v2.5 --- fixed


(Reporter: ochameau, Assigned: ochameau)




(1 file, 3 obsolete files)

Once bug 1007061 lands, there will still be some resource in /devtools/app-manager/, files being still used by WebIDE.
We should integrate them into WebIDE folders or get rid of these deps.
Attached patch patch v2 (obsolete) — Splinter Review
Also includes some require(Services) / require(promise) cleanups
as well as some removal of app-manager references.
(that are not about the webide/modules/app-manager module!)

I also tried to clean bugzilla from some app-manager bugs/references.
Attachment #8677603 - Attachment is obsolete: true
Assignee: nobody → poirot.alex
Attached patch patch v3 (obsolete) — Splinter Review
Last time you are going to hear about the app manager ;-)

Wait?! No, there is this the webide module!!
Attachment #8680711 - Flags: review?(jryans)
Attachment #8678990 - Attachment is obsolete: true
Comment on attachment 8680711 [details] [diff] [review]
patch v3

Review of attachment 8680711 [details] [diff] [review]:

Great work! :D

::: browser/locales/
@@ +77,5 @@
>      locale/browser/devtools/connection-screen.dtd  (%chrome/browser/devtools/connection-screen.dtd)
>      locale/browser/devtools/ (%chrome/browser/devtools/
>      locale/browser/devtools/font-inspector.dtd     (%chrome/browser/devtools/font-inspector.dtd)
>      locale/browser/devtools/         (%chrome/browser/devtools/
> +    locale/browser/devtools/ (%chrome/browser/devtools/

I believe this will cause all the strings to be re-translated... not sure it's worth it?  On the other hand, it's probably left untranslated in many locales.  I leave it up to you.
Attachment #8680711 - Flags: review?(jryans) → review+
Attached patch patch v4Splinter Review
Do not rename
Attachment #8681885 - Flags: review+
Attachment #8680711 - Attachment is obsolete: true
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 45
Product: Firefox → DevTools
Product: DevTools → DevTools Graveyard
You need to log in before you can comment on or make changes to this bug.