1216604 - Ensure that Mozilla list are downloaded immediately in new profiles

Status: VERIFIED FIXED

(Toolkit :: Safe Browsing, defect)

Description

[François Marier [:francois]]

As a result of fixing bug 1175562, we now have to wait up to 5 minutes before the TP list is available and TP is working (see https://bugzilla.mozilla.org/show_bug.cgi?id=1177085#c68).

We should ship with "browser.safebrowsing.provider.mozilla.nextupdatetime = 42" or similar in order to force an immediate update the first time.

Comment 1

[François Marier [:francois]]

Note: in terms of server load, this change makes 44 act like 42 and 43 so we're not making it worse.

Comment 2

[François Marier [:francois]]

Attachment: bug1216604.patch

Comment 3

[Gian-Carlo Pascutto [:gcp]]

Comment on attachment 8676589 [details] [diff] [review]
bug1216604.patch

Review of attachment 8676589 [details] [diff] [review]:
-----------------------------------------------------------------

::: modules/libpref/init/all.js
@@ +4811,5 @@
>  
>  pref("browser.safebrowsing.provider.mozilla.lists", "mozstd-track-digest256,mozstd-trackwhite-digest256,mozfull-track-digest256");
>  pref("browser.safebrowsing.provider.mozilla.updateURL", "https://shavar.services.mozilla.com/downloads?client=SAFEBROWSING_ID&appver=%VERSION%&pver=2.2");
>  pref("browser.safebrowsing.provider.mozilla.gethashURL", "https://shavar.services.mozilla.com/gethash?client=SAFEBROWSING_ID&appver=%VERSION%&pver=2.2");
> +pref("browser.safebrowsing.provider.mozilla.nextupdatetime", "1"); // date in the past to force immediate download in new profiles

The common style in all.js seems to be to put the comment on a separate line before.

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/d30f27ee811a

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/d30f27ee811a

Comment 6

[Paul Silaghi, QA [:pauly]]

(In reply to François Marier [:francois] from comment #0)
> As a result of fixing bug 1175562, we now have to wait up to 5 minutes
> before the TP list is available and TP is working
TP works now right after the browser starts.
Verified fixed FF 44.0a1 (2015-10-25) Win 7.