1216611 - add a MakeUniqueFallible<T[]> (and maybe <T>) function

Status: RESOLVED FIXED

(Core :: MFBT, defect)

Description

[Nathan Froyd [:froydnj]]

In converting a few nsAuto*Ptr things to UniquePtr, one pattern that comes up is:

  mAutoPtr = new (fallible) T[...];

which has to be converted like so:

  mUniquePtr.reset(new (fallible) T[...]);

I think converting it like so would be nicer:

  mUniquePtr = MakeUniqueFallible<T[]>(...);

which is a little longer, but reads a little more idiomatically and doesn't use |new|.

Comment 1

[Jeff Walden [:Waldo]]

Reasonable.  Separate header from the existing, is all I want here.  :-)  If we adopt <memory> at some point, want to keep extensions separated out.

Comment 2

[Mike Hommey [:glandium]]

How about mUniquePtr = MakeUnique<T[]>(..., fallible) ?

Comment 3

[Jeff Walden [:Waldo]]

Don't think so.  It seems very worth preserving the sense that the arguments passed in, are exactly passed along.  Not to mention there'd then be ambiguity with a constructor that took a |fallible| as its last argument.

Comment 4

[Nathan Froyd [:froydnj]]

Attachment: add mozilla::MakeUniqueFallible and convert uses throughout the tree

Chose to call the file MakeUniqueExtensions in case we ever want to have
UniqueFreePtr etc.

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/9bfc35f6d7ab

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/9bfc35f6d7ab

Comment 7

[Timothy Nikkel (:tnikkel)]

Attachment: header only uplift for beta

Approval Request Comment
[Feature/regressing bug #]: none
[User impact if declined]: need this to uplift bug 1235605
[Describe test coverage new/current, TreeHerder]: none
[Risks and why]: safe
[String/UUID change made/needed]: none

Comment 8

[Nathan Froyd [:froydnj]]

Comment on attachment 8703908 [details] [diff] [review]
header only uplift for beta

Review of attachment 8703908 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM!

Comment 9

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Comment on attachment 8703908 [details] [diff] [review]
header only uplift for beta

Need to fix a sec-mod issue. Beta44+

Comment 10

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/releases/mozilla-beta/rev/3b68f716c82b

Comment 11

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/3b68f716c82b