1216627 - If youtube app isn't installed, in PB you're prompted to open a link in Nightly when tapping youtube video

Status: RESOLVED WORKSFORME

(Firefox for Android Graveyard :: General, defect)

Description

[:Margaret Leibovic]

Attachment: Screenshot 2015-10-20 12.47.52.PNG

Mike, do you know what's going on here?

Comment 1

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

The containing link element is:

<a href="#" class="_mvo" onclick="return koya.onEvent(arguments[0]||window.event,'22_2')" role="button" title="Play video">

The DOM inspector provides an "ev" (event?) button that lists a "http://m.youtube.com..." url with some other tags I don't entirely understand – I'll follow the JS function.

Comment 2

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Except everything is minified – shucks.

If I had to guess, we're firing off an Intent instead of opening the url directly – unclear why it doesn't prompt to open in other browsers.

I'll keep investigating.

Comment 3

[:Margaret Leibovic]

This issue is probably complicated by the fact that we special-case YouTube URLs.

Mike, let's look into what happens for other types of intents if no app is installed.

I think the main thing we want to solve here is why we're showing "Nightly" in the prompt if you have no valid app installed to handle an intent.

Comment 4

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Youtube videos are playing directly in the browser now on my GS4 so I can't repro. I'll check what happens for other apps as per comment 3.

I noticed the special-case youtube handling code doesn't appear to be necessary anymore. afaict, originally implemented in bug 936851, it checks to see if there are special handlers and if not, requests the HTML5 video. However, I removed this code and the HTML5 video still appears. Notably, their instructions on how to request HTML5 video, via [1], are no longer active.

Richard, do you agree it's safe to remove this code?

[1]: https://bugzilla.mozilla.org/show_bug.cgi?id=936851#c10

Comment 5

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

(In reply to Michael Comella (:mcomella) from comment #4)
> I'll check what happens for other apps as per comment 3.

Using my test page [1] and going to the "Browseable intents" category, "Nothing specified", we open about:neterror when there are no apps to handle the page via the IntentHelper.openNoHandler [2]. The bug described in this page must have used a different code path (that we could have caught with the debugger so it's a shame I can't repro). Perhaps this other code path was triggered by the url being set dynamically (see comment 1).

This could be indicative of larger issues but I don't see anything actionable to do from here – I think we should wait to see the issue again.

[1]: https://people.mozilla.org/~mcomella/test/uri.html
[2]: https://mxr.mozilla.org/mozilla-central/source/mobile/android/base/IntentHelper.java?rev=429dbd2ac169#165

Comment 6

[Richard Newman [:rnewman]]

The explicit HTML5 workaround was because YouTube didn't serve a particularly useful page to us -- we'd get this inline video in the page, or a Flash video, and this workaround would at least give us a new tab to play full-screen HTML5 video if they had it.

YouTube has made a bunch of changes in the last year or two, so I could certainly imagine that they just do the right thing here and we can remove our special handling entirely. Mike, what do you think?

Comment 7

[Mike Taylor [:miketaylr]]

(In reply to Richard Newman [:rnewman] from comment #6)
> YouTube has made a bunch of changes in the last year or two, so I could
> certainly imagine that they just do the right thing here and we can remove
> our special handling entirely. Mike, what do you think?

Yeah, I agree. We now get in-browser video/mp4 video served to us now (doesn't matter if you have the YT app enabled or disabled). The fix was rolled out last week (not sure it's 100% deployed, but all my testing suggests it is), so that might explain some of the can't reproduce-iness of this bug. Seems like the workaround can be ripped out.

Comment 8

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

(In reply to Mike Taylor [:miketaylr] from comment #7)
> Seems like the workaround can be ripped out.

Filed bug 1216627.

Comment 9

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

(In reply to Mike Taylor [:miketaylr] from comment #7)
> Seems like the workaround can be ripped out.

Filed bug 1219950.