1216683 - PushServiceWebSocket: unregister should always return true even if we are offline

Status: RESOLVED FIXED

(Core :: DOM: Push Subscriptions, defect)

Description

[Dragana Damjanovic [:dragana]]

I have spotted that if we are offline ( also if pref connection.enable is false )
unregister will return false. 
For the Http2 version that is by the spec but for WebSocket version we should return true always (even if we do not sen unregister request to the push server).

Comment 1

[Dragana Damjanovic [:dragana]]

Attachment: bug_1216683.patch

Comment 2

[Dragana Damjanovic [:dragana]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=c7dc38aec2d9

Comment 3

[Lina Butler (ex-Mozilla)]

Comment on attachment 8679440 [details] [diff] [review]
bug_1216683.patch

Review of attachment 8679440 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/push/PushService.jsm
@@ +924,5 @@
>    _sendRequest: function(action, aRecord) {
>      if (this._state == PUSH_SERVICE_CONNECTION_DISABLE) {
>        return Promise.reject({state: 0, error: "Service not active"});
>      } else if (this._state == PUSH_SERVICE_ACTIVE_OFFLINE) {
> +      if (this._serviceType == "WebSocket" && action == "unregister") {

Should this be `this._service.serviceType() == "WebSocket"`?

Comment 4

[Dragana Damjanovic [:dragana]]

Attachment: bug_1216683.patch

:)

Comment 5

[Lina Butler (ex-Mozilla)]

Comment on attachment 8679515 [details] [diff] [review]
bug_1216683.patch

Review of attachment 8679515 [details] [diff] [review]:
-----------------------------------------------------------------

Awesome, thanks!

Comment 6

[Dragana Damjanovic [:dragana]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=3aee08f085a3

Comment 7

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/b6cf4c726f70

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/b6cf4c726f70