Closed Bug 1216800 Opened 9 years ago Closed 11 months ago

some chrome code may be incorrectly receiving spoofed devicePixelRatio

Categories

(Core :: DOM: Core & HTML, defect)

defect

Tracking

()

RESOLVED WORKSFORME

People

(Reporter: arthur, Unassigned)

References

(Blocks 1 open bug)

Details

(Whiteboard: [fingerprinting])

:khuey points out in bug 418986, comment 69, that some chrome code may be incorrectly receiving false devicePixelRatio values when privacy.resistFingerprinting is active.

We need to figure out if these calls should be getting the spoofed or true value, and fix if necessary.
If it turns out these calls should not be spoofed, then one possible fix is to apply the following patch:
https://github.com/arthuredelstein/tor-browser/commit/4c316cacb6383c9b60606630ef331301fa51da10
and use nsDOMWindowUtils::GetScreenPixelsPerCSSPixel(...) instead of nsIDOMWindow::GetDevicePixelRatio(...) from chrome code.
Component: DOM → DOM: Core & HTML
Whiteboard: [fingerprinting]
Severity: normal → S3

I don't believe this is an issue anymore. We have CallerType and fine-grained checks on GetDevicePixelRatio, and I don't see very many callers of GetDevicePixelRatio in general - really just the bindings to the JS attribute.

Status: NEW → RESOLVED
Closed: 11 months ago
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.