1216853 - B2G RIL: chain promises properly in test_network_interface_mtu.js

Status: RESOLVED FIXED

(Firefox OS Graveyard :: RIL, defect)

Description

[Jessica Jong [:jessica] (inactive)]

I get timeout sometimes on this test when running locally. The reason seems to be that promises are not chained properly.

Comment 1

[Jessica Jong [:jessica] (inactive)]

Attachment: patch.

Comment 2

[Jessica Jong [:jessica] (inactive)]

Comment on attachment 8676609 [details] [diff] [review]
patch.

Edgar, may I have your review on this? Thanks.

try:
https://treeherder.allizom.org/#/jobs?repo=try&revision=91f9ca461cc8&exclusion_profile=false

Comment 3

[Edgar Chen [:edgar]]

Comment on attachment 8676609 [details] [diff] [review]
patch.

Review of attachment 8676609 [details] [diff] [review]:
-----------------------------------------------------------------

Good catch, thank you.

::: dom/system/gonk/tests/marionette/test_network_interface_mtu.js
@@ +59,5 @@
>    log("= testDefaultDataCallMtu =");
>  
>    return setDataEnabledAndWait(true)
>      .then(aNetworkInfo => {
> +      return verifyMtu(aNetworkInfo.name, TEST_MTU1);

Or you can just remove the parentheses, for example

.then(aNetworkInfo => verifyMtu(aNetworkInfo.name, TEST_MTU1))

Comment 4

[Jessica Jong [:jessica] (inactive)]

(In reply to Edgar Chen [:edgar][:echen] from comment #3)
> Comment on attachment 8676609 [details] [diff] [review]
> patch.
> 
> Review of attachment 8676609 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> Good catch, thank you.
> 
> ::: dom/system/gonk/tests/marionette/test_network_interface_mtu.js
> @@ +59,5 @@
> >    log("= testDefaultDataCallMtu =");
> >  
> >    return setDataEnabledAndWait(true)
> >      .then(aNetworkInfo => {
> > +      return verifyMtu(aNetworkInfo.name, TEST_MTU1);
> 
> Or you can just remove the parentheses, for example
> 
> .then(aNetworkInfo => verifyMtu(aNetworkInfo.name, TEST_MTU1))

even better, thanks!

Comment 5

[Jessica Jong [:jessica] (inactive)]

Attachment: patch. r=echen

Comment 6

[Pulsebot]

https://hg.mozilla.org/integration/b2g-inbound/rev/1280b5e0bbcf

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/1280b5e0bbcf