Closed Bug 1216857 Opened 4 years ago Closed 4 years ago

[TextSelection] selected text is covered by selection bubble after switching from portrait mode to landscape mode.

Categories

(Core :: Selection, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla44
Tracking Status
firefox44 --- fixed

People

(Reporter: jeremychen, Assigned: jeremychen)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

+++ This bug was initially created as a clone of Bug #1210341 +++

Steps to reproduce:
1. Open a rotatable app. (ex. browser app)
2. Type 10 'a's, a space, and 10 'b's on rocketbar. It's essential that those 'b's are long enough to make the input scroll.
3. Long press to select all a's and 'b's.
4. Rotate the device to switch to landscape mode.

Actual result:
Selection bubble covers the selected text.

Expected result:
Selection bubble is displayed in the right position, which is the bottom of the selected text. The selected text should not be covered.

Build ID               20151020150236
Gaia Revision          11eb5d4cb2675d359d277ae17772bc75f7ccedbc
Gaia Date              2015-10-20 16:22:28
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/f397034950304b845175f8dab8fccbdd0e8bf995
Gecko Version          44.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20151020.182846
Firmware Date          Tue Oct 20 18:28:58 EDT 2015
Bootloader             L1TC000118D0
Summary: [TextSelection] selected text is covered by selection bubble after changing to landscape mode. → [TextSelection] selected text is covered by selection bubble after switching from portrait mode to landscape mode.
Bug 1210341 did fixed selecting text in landscape. In this bug, I think something need to be take care of while changing from portrait mode to landscape mode.
No longer depends on: 1210341
Assignee: nobody → jeremychen
Bug 1216857 - Notify selection dialog to update its position if carets are logically visible. r=TYLin
Attachment #8677235 - Flags: review?(tlin)
Attachment #8677235 - Flags: review?(tlin) → review+
Comment on attachment 8677235 [details]
MozReview Request: Bug 1216857 - Notify selection dialog to update its position if carets are logically visible. r=TYLin

https://reviewboard.mozilla.org/r/22903/#review20433
Comment on attachment 8677235 [details]
MozReview Request: Bug 1216857 - Notify selection dialog to update its position if carets are logically visible. r=TYLin

Bug 1216857 - Notify selection dialog to update its position if carets are logically visible. r=TYLin
Attachment #8677235 - Flags: review+ → review?(tlin)
Comment on attachment 8677235 [details]
MozReview Request: Bug 1216857 - Notify selection dialog to update its position if carets are logically visible. r=TYLin

https://reviewboard.mozilla.org/r/22903/#review20521
Attachment #8677235 - Flags: review?(tlin) → review+
Ting-Yu, thanks for your review.

Try looks positive, except Linux debug Wr which seems a known issue. Please check-in the patches.
https://hg.mozilla.org/mozilla-central/rev/1650689e3fdb
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla44
You need to log in before you can comment on or make changes to this bug.