Closed
Bug 1216857
Opened 9 years ago
Closed 9 years ago
[TextSelection] selected text is covered by selection bubble after switching from portrait mode to landscape mode.
Categories
(Core :: DOM: Selection, defect)
Core
DOM: Selection
Tracking
()
RESOLVED
FIXED
mozilla44
Tracking | Status | |
---|---|---|
firefox44 | --- | fixed |
People
(Reporter: chenpighead, Assigned: chenpighead)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
+++ This bug was initially created as a clone of Bug #1210341 +++
Steps to reproduce:
1. Open a rotatable app. (ex. browser app)
2. Type 10 'a's, a space, and 10 'b's on rocketbar. It's essential that those 'b's are long enough to make the input scroll.
3. Long press to select all a's and 'b's.
4. Rotate the device to switch to landscape mode.
Actual result:
Selection bubble covers the selected text.
Expected result:
Selection bubble is displayed in the right position, which is the bottom of the selected text. The selected text should not be covered.
Build ID 20151020150236
Gaia Revision 11eb5d4cb2675d359d277ae17772bc75f7ccedbc
Gaia Date 2015-10-20 16:22:28
Gecko Revision https://hg.mozilla.org/mozilla-central/rev/f397034950304b845175f8dab8fccbdd0e8bf995
Gecko Version 44.0a1
Device Name flame
Firmware(Release) 4.4.2
Firmware(Incremental) eng.cltbld.20151020.182846
Firmware Date Tue Oct 20 18:28:58 EDT 2015
Bootloader L1TC000118D0
Assignee | ||
Updated•9 years ago
|
Summary: [TextSelection] selected text is covered by selection bubble after changing to landscape mode. → [TextSelection] selected text is covered by selection bubble after switching from portrait mode to landscape mode.
Assignee | ||
Comment 1•9 years ago
|
||
Bug 1210341 did fixed selecting text in landscape. In this bug, I think something need to be take care of while changing from portrait mode to landscape mode.
Assignee | ||
Updated•9 years ago
|
Assignee: nobody → jeremychen
Assignee | ||
Comment 2•9 years ago
|
||
Bug 1216857 - Notify selection dialog to update its position if carets are logically visible. r=TYLin
Attachment #8677235 -
Flags: review?(tlin)
Updated•9 years ago
|
Attachment #8677235 -
Flags: review?(tlin) → review+
Comment 3•9 years ago
|
||
Comment on attachment 8677235 [details]
MozReview Request: Bug 1216857 - Notify selection dialog to update its position if carets are logically visible. r=TYLin
https://reviewboard.mozilla.org/r/22903/#review20433
Assignee | ||
Comment 4•9 years ago
|
||
Comment on attachment 8677235 [details]
MozReview Request: Bug 1216857 - Notify selection dialog to update its position if carets are logically visible. r=TYLin
Bug 1216857 - Notify selection dialog to update its position if carets are logically visible. r=TYLin
Attachment #8677235 -
Flags: review+ → review?(tlin)
Comment 5•9 years ago
|
||
Comment on attachment 8677235 [details]
MozReview Request: Bug 1216857 - Notify selection dialog to update its position if carets are logically visible. r=TYLin
https://reviewboard.mozilla.org/r/22903/#review20521
Attachment #8677235 -
Flags: review?(tlin) → review+
Assignee | ||
Comment 6•9 years ago
|
||
Ting-Yu, thanks for your review.
Try looks positive, except Linux debug Wr which seems a known issue. Please check-in the patches.
Assignee | ||
Updated•9 years ago
|
Keywords: checkin-needed
Keywords: checkin-needed
Comment 8•9 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox44:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla44
You need to log in
before you can comment on or make changes to this bug.
Description
•