1216895 - Add more comments and assertion to make Gonk PDM threading model more clear.

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect, P2)

Description

[John Lin [:jhlin][:jolin]]

Follow jya's suggestion in Bug 1199809 comment 19.

Comment 1

[John Lin [:jhlin][:jolin]]

Attachment: assert that decoder methods are run on correct thread.

Comment 2

[John Lin [:jhlin][:jolin]]

Attachment: assert that decoder methods are run on correct thread. r=jya

Comment 3

[John Lin [:jhlin][:jolin]]

Comment on attachment 8685244 [details] [diff] [review]
assert that decoder methods are run on correct thread. r=jya

Rebase and carry r+ from jya.

Comment 4

[John Lin [:jhlin][:jolin]]

Try result: https://treeherder.mozilla.org/#/jobs?repo=try&revision=eaa74da920cb

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/d79e105ced68

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/d79e105ced68

Comment 7

[John Lin [:jhlin][:jolin]]

Comment on attachment 8685244 [details] [diff] [review]
assert that decoder methods are run on correct thread. r=jya

NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings.

[Approval Request Comment]
This patch doesn't impact user by itself but the patch in bug 1222919 cannot be merged clearly without it. Since the risk of uplifting is nearly none I'd like to request uplifting. Thanks.

Comment 8

[Mahendra Potharaju [:mahe]]

Comment on attachment 8685244 [details] [diff] [review]
assert that decoder methods are run on correct thread. r=jya

Approved for 2.5 uplift. 

Thanks

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/df8d5c3cf615