1216898 - [RFE] "Add keyword for this search" should create a search (opensearch xml file)

Status: RESOLVED DUPLICATE of bug 261124

(Firefox :: Search, defect)

Description

[Christian Stadelmann]

User Agent: Mozilla/5.0 (compatible)
Build ID: 20151015125802

Steps to reproduce:

Right-click on any search field and activate "Add keyword for this search". 


Actual results:

Firefox opens the "New Bookmark" dialog. After pressing "Save" this search is stored as a bookmark.


Expected results:

Open a dialog for search engines, not for bookmarks. At least change the title.

Save the "bookmark" as search plugin file (opensearch XML) to [firefox profile]/searchplugins. Make it available on about:preferences#search instead of hiding it in a (probably) massive amount of bookmarks. This dialog title should be changed e.g. to "Search" or "Search Engine". This feature could be integrated into firefox's search bar reusing the UI for adding a search from an opensearch xml file provided by websites.

Using the "bookmarks" feature for search engines is unintuitive:
* Bookmarks are not Search Engines
* Search Engines are not Bookmarks
* Search Engines stored as Bookmarks (with URLs including %s) don't make sense being used as bookmarks
* Not all Bookmarks can be used as Search Engines (they need to contain a %s and have a keyword assigned)
All of those issues might baffle non-expert firefox users.

On the long term this can help removing bookmark keywords completely as started in https://bugzilla.mozilla.org/show_bug.cgi?id=1145063

There should be a straight-forward way to migrate all search-bookmark (i.e. bookmarks with keywords assigned) to search engines and drop the bookmark keywords feature completely.

Comment 1

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

For migrating smart keyword bookmarks to search engines, the bug is bug 648398.
For adding search inputs as search engines, see bug 261124.