Closed
Bug 1216941
Opened 9 years ago
Closed 9 years ago
Remove outset class from custom notification bar bindings
Categories
(Firefox :: General, defect)
Firefox
General
Tracking
()
RESOLVED
FIXED
Firefox 44
Tracking | Status | |
---|---|---|
firefox44 | --- | fixed |
People
(Reporter: dao, Assigned: |chirath, Mentored)
References
Details
(Whiteboard: [good first bug][lang=xul])
Attachments
(1 file)
Bug 1162635 removed 'outset' in the base binding (toolkit/content/widgets/notification.xml), but it's still present in two custom bindings where we need to remove it too: http://hg.mozilla.org/mozilla-central/annotate/bdae48998e3b/browser/base/content/sync/notification.xml#l96 http://hg.mozilla.org/mozilla-central/annotate/bdae48998e3b/browser/components/translation/translation-infobar.xml#l22
Comment 1•9 years ago
|
||
sync's thing is likely going away in bug 691849.
Assignee | ||
Comment 2•9 years ago
|
||
Hey I would like to work on this bug ,Can u please help me how to go about it.
Assignee | ||
Comment 3•9 years ago
|
||
Assignee | ||
Updated•9 years ago
|
Attachment #8677911 -
Flags: review?(dao)
Reporter | ||
Comment 4•9 years ago
|
||
Comment on attachment 8677911 [details] [diff] [review] Removed outset class from browser/base/content/sync/notification.xml and / browser/components/translation/translation-infobar.xml Looks good, thanks!
Attachment #8677911 -
Flags: review?(dao) → review+
Reporter | ||
Updated•9 years ago
|
Assignee: nobody → chirath.02
Assignee | ||
Comment 6•9 years ago
|
||
Thanks :) So is this bug fixed now ,coz I don't know how it works ,as i am newbie and just started today.
Reporter | ||
Comment 7•9 years ago
|
||
(In reply to Chirath R [:|chirath] from comment #6) > Thanks :) > So is this bug fixed now ,coz I don't know how it works ,as i am newbie and > just started today. I've checked the patch in to an integration repository from where it will be merged to mozilla-central soon. The bug will automatically be resolved then. You don't need to do anything at this point.
Assignee | ||
Comment 8•9 years ago
|
||
Okay ,Thanks so much :)
Comment 9•9 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/62b2b335cc85
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 44
You need to log in
before you can comment on or make changes to this bug.
Description
•