1217131 - Filtering should show complete objects that match

Status: RESOLVED DUPLICATE of bug 1358192

(DevTools :: JSON Viewer, defect, P3)

Description

[Jeff Griffiths (:canuckistani) (:⚡︎)]

STR: 

1. open this url: http://live-menu.staugustinesvancouver.com/taps.json
2. filter on 'IPA'

Expected: I should see the entire object that contains property values that match 'IPA'

Actual: the objects themselves are filtered so you can't see the rest of the property names or values

Comment 1

[UKS]

I tested this based on your steps 1 and 2. I used the filter option on the browser and it showed the entire JSON object, wrapped of course and highlights all places marked IPA. Am I doing the test properly?

Comment 2

[Jeff Griffiths (:canuckistani) (:⚡︎)]

Attachment: json-viewer-filter.gif

I've attached a gif of what I see in current Nightly. Notice when the filter is applied I only see properties in the 'Ninkasi IPA' object that contain 'IPA', but when I remove the filter completely I see the full object.

Comment 3

[armisael]

I totally agree on this. For example, on the following json, when searching for "address" I'd like to see the whole address object (with all its fields, "provinceCode", "macroregion", ...); it would also be very helpful if it expanded the json automatically (as of 45.0a2 (2016-01-24) the json is not expanded when a search is performed).

{
  "_type": "person",
  "_id": "e56fdc1eeef8",
  "_score": 16.13567,
  "_source": {
    "taxID": "***",
    "address": {
      "provinceCode": "TV",
      "macroregion": "Nord-est",
      "postcode": "31026",
      "municipality": "Sarmede",
      "province": "Treviso",
      "toponym": "***",
      "streetName": "***",
      "streetNumber": "***",
      "fullAddress": "***, 31026, Sarmede (TV)",
      "region": "Veneto",
      "state": "Italia"
    },
    "name": "***",
    "gender": "M",
    "birthPlace": {
      "provinceCode": "TV",
      "macroregion": "Nord-est",
      "municipality": "**",
      "province": "Treviso",
      "region": "Veneto",
      "state": "Italia"
    },
    "surname": "***",
    "birthDate": "1962-01-23"
  }
}

Comment 4

[Bryan Clark (DevTools PM) [:clarkbw]]

Attachment: 1217131.patch

Just took a rough stab at this by passing down the search match status as a bool.  It works but needs some help.

The search highlight needs to not highlight parents e.g. not(.hasChildren)
Also the search highlight color is purposely hideous
And we should open the objects by default, this can be done with member.open = true but I saw some perf issues when doing it.

Comment 5

[Bryan Clark (DevTools PM) [:clarkbw]]

Attachment: Screen Shot 2016-02-17 at 9.13.38 AM.png

screenshot of the patch working