Closed Bug 1217151 Opened 4 years ago Closed 4 years ago

Black checks on Android 4 in Sync Settings

Categories

(Firefox for Android :: General, defect)

All
Android
defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 45
Tracking Status
firefox44 --- verified
firefox45 --- verified
b2g-v2.5 --- fixed
fennec 44+ ---

People

(Reporter: mcomella, Assigned: mcomella)

References

Details

Attachments

(3 files)

No description provided.
Apparently, on Android 4, we use holo checks in the rest of the interface and the material checks in Sync.
Bug 1217151 - Inherit from Gecko.Preferences in SyncStatusActivity. r=nalexander

Tested on 5, 4, & 2.3.
Attachment #8680721 - Flags: review?(nalexander)
Comment on attachment 8680721 [details]
MozReview Request: Bug 1217151 - Inherit from Gecko.Preferences in SyncStatusActivity. r=nalexander

https://reviewboard.mozilla.org/r/23673/#review21189

lgtm.  Could you try opening the menu (hardware menu button or "More..." entry) and see if it's transparent?  You may have fixed that too!
Attachment #8680721 - Flags: review?(nalexander) → review+
Comment on attachment 8680721 [details]
MozReview Request: Bug 1217151 - Inherit from Gecko.Preferences in SyncStatusActivity. r=nalexander

Approval Request Comment
[Feature/regressing bug #]: bug 1201206
[User impact if declined]:
  Users will see inconsistent check marks in the Preference activity on Android 4.

[Describe test coverage new/current, TreeHerder]: Tested locally.

[Risks and why]: Low – we inherit from an existing preferences style, rather than the style used for the main application. It's a small activity that I tested on all major configurations so it's unlikely to cause issues.

[String/UUID change made/needed]: None
Attachment #8680721 - Flags: approval-mozilla-aurora?
https://hg.mozilla.org/mozilla-central/rev/df3d8c831696
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 45
Comment on attachment 8680721 [details]
MozReview Request: Bug 1217151 - Inherit from Gecko.Preferences in SyncStatusActivity. r=nalexander

let's take it!
Attachment #8680721 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
removing the b2g 2.5 flag since this commit has been reverted due to an incorrect merge, sorry for the confusion
Verified as fixed using:
Device: Moto X (Android 4.4)
Builds: Firefox for Android 44.0a2 and 45.0a1 (2015-11-24)
You need to log in before you can comment on or make changes to this bug.