1217151 - Black checks on Android 4 in Sync Settings

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Attachment: device-2015-10-21-154137.png

Comment 1

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Apparently, on Android 4, we use holo checks in the rest of the interface and the material checks in Sync.

Comment 2

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Attachment: MozReview Request: Bug 1217151 - Inherit from Gecko.Preferences in SyncStatusActivity. r=nalexander

Bug 1217151 - Inherit from Gecko.Preferences in SyncStatusActivity. r=nalexander

Tested on 5, 4, & 2.3.

Comment 3

[Nick Alexander :nalexander [he/him]]

Comment on attachment 8680721 [details]
MozReview Request: Bug 1217151 - Inherit from Gecko.Preferences in SyncStatusActivity. r=nalexander

https://reviewboard.mozilla.org/r/23673/#review21189

lgtm.  Could you try opening the menu (hardware menu button or "More..." entry) and see if it's transparent?  You may have fixed that too!

Comment 4

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

https://hg.mozilla.org/integration/fx-team/rev/df3d8c8316968efc61946c02c438d387a8bbddfc
Bug 1217151 - Inherit from Gecko.Preferences in SyncStatusActivity. r=nalexander

Comment 5

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Comment on attachment 8680721 [details]
MozReview Request: Bug 1217151 - Inherit from Gecko.Preferences in SyncStatusActivity. r=nalexander

Approval Request Comment
[Feature/regressing bug #]: bug 1201206
[User impact if declined]:
  Users will see inconsistent check marks in the Preference activity on Android 4.

[Describe test coverage new/current, TreeHerder]: Tested locally.

[Risks and why]: Low – we inherit from an existing preferences style, rather than the style used for the main application. It's a small activity that I tested on all major configurations so it's unlikely to cause issues.

[String/UUID change made/needed]: None

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/df3d8c831696

Comment 7

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8680721 [details]
MozReview Request: Bug 1217151 - Inherit from Gecko.Preferences in SyncStatusActivity. r=nalexander

let's take it!

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/e8d4a3fe4645

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/df3d8c831696

Comment 10

[Carsten Book [:Tomcat]]

removing the b2g 2.5 flag since this commit has been reverted due to an incorrect merge, sorry for the confusion

Comment 11

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/e8d4a3fe4645

Comment 12

[Teodora Vermesan (:TeoVermesan)]

Attachment: Screenshot from 2015-11-25 16:19:20.png

Verified as fixed using:
Device: Moto X (Android 4.4)
Builds: Firefox for Android 44.0a2 and 45.0a1 (2015-11-24)