1217211 - Redirect /firefox/choose/ to /firefox/new/ until November 3rd

Status: VERIFIED FIXED

(www.mozilla.org :: Pages & Content, defect)

Description

[Cory Price [:ckprice] (bugmail disabled, NI me!)]

Product marketing would like to fire off a round of placements ahead of November 3rd. Starting on 10/26 (Monday).

We can't use /choose/ until Nov 3 since it talks about Tracking Protection and SmartOn Tracking.

Ideally we use the same URL before and after November 3rd so we don't have to go back through all executions and update the URL with the agency partner. We could also experience delays on the online properties if pages have cached the /new URL.

We could use a single waffle switch (tracking-protection) to turn the redirect on/off. 

Example:
tracking-protection OFF = /choose/ --> /new/
tracking-protection ON = /choose/

note: we need to save any query parameters through the redirect.

NI :espressive - any way we can have this up on production this week?

Comment 1

[Cory Price [:ckprice] (bugmail disabled, NI me!)]

To add complexity, it would be good to be able to continue to view the /choose/ page on the staging server running up to the campaign.

Comment 2

[Schalk Neethling [:espressive]]

Alrighty! So here is the thing. If I add a redirect and waffle this, it actually wraps the view (/choose) that will be redirected so, we cannot have two separate switches for the page and the redirect, they will inevitable be the same.

This means if the switch, say tracking-protection-rdirect is on, it will redirect, if it is off /choose will throw a 404

One option would be to merge the redirect bits to master but, before that is merged, I then have to create a new demo branch from master, and push this to a demo server.

That way /choose will load as normal on the demo server but, on dev, stage and production in will redirect.

With all of that said, perhaps there is a simpler solution that Josh or Paul knows about so NI :jgmize or :pmac - Thanks!

Comment 3

[Schalk Neethling [:espressive]]

Turns out it is supoer simple, this is all that was needed:

page('firefox/choose', 'firefox/choose.html',
        decorators=waffle_switch('tracking-protection', 'firefox.new'))

Thanks pmac and agibson!

Comment 4

[Schalk Neethling [:espressive]]

Whops, seems like I spoke to soon. A little more is needed. Still all is good, PR coming.

Comment 5

[Cory Price [:ckprice] (bugmail disabled, NI me!)]

Can we make this a priority to get pushed out to production tomorrow? Thanks!

Comment 6

[Schalk Neethling [:espressive]]

Attachment: Link to Github pull-request: https://github.com/mozilla/bedrock/pull/3469

Comment 7

[Schalk Neethling [:espressive]]

The waffle switch for this is tracking-protection-redirect

Comment 8

[[github robot]]

Commits pushed to master at https://github.com/mozilla/bedrock

https://github.com/mozilla/bedrock/commit/5dc9a1901d56b8f46ac08d1ac9f614ab8c40e7b0
Fix Bug 1217211, redirect choose to new until November 3rd

https://github.com/mozilla/bedrock/commit/c7252b483a1e9cc44b0ee99d3ce2252ef8f7c476
Merge pull request #3469 from schalkneethling/bug1217211-redirect-choose-to-new-upto-3nov

Fix Bug 1217211, redirect choose to new until a waffle switch is flipped

Comment 9

[Rebecca Billings [:rbillings]]

Verified on prod