1217248 - Add the ability to invert CensusTreeNode trees

Status: RESOLVED FIXED

(DevTools :: Memory, defect)

Comment 1

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

Attachment: Add the ability to invert CensusTreeNode trees

Comment 2

[Jordan Santell [:jsantell] [@jsantell]]

Comment on attachment 8677166 [details] [diff] [review]
Add the ability to invert CensusTreeNode trees

Review of attachment 8677166 [details] [diff] [review]:
-----------------------------------------------------------------

lgtm, but should create bugs or atleast notes about the 4(?) TODOs listed here

::: devtools/shared/heapsnapshot/census-tree-node.js
@@ +69,5 @@
> +  return `FRAME,${frame.functionDisplayName},${frame.source},${frame.line},${frame.column},${frame.asyncCause}`;
> +};
> +
> +/**
> + * TODO FITZGEN

TODO what?

Comment 3

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=b70824799c98

Comment 4

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

(In reply to Jordan Santell [:jsantell] [@jsantell] from comment #2)
> lgtm, but should create bugs or atleast notes about the 4(?) TODOs listed
> here

Woops, just forgot to fill out the doc comments... >_<

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/e472a823244c

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/e472a823244c