Closed Bug 1217248 Opened 4 years ago Closed 4 years ago

Add the ability to invert CensusTreeNode trees

Categories

(DevTools :: Memory, defect)

defect
Not set

Tracking

(firefox44 fixed)

RESOLVED FIXED
Firefox 44
Tracking Status
firefox44 --- fixed

People

(Reporter: fitzgen, Assigned: fitzgen)

References

Details

Attachments

(1 file)

No description provided.
Assignee: nobody → nfitzgerald
Status: NEW → ASSIGNED
Comment on attachment 8677166 [details] [diff] [review]
Add the ability to invert CensusTreeNode trees

Review of attachment 8677166 [details] [diff] [review]:
-----------------------------------------------------------------

lgtm, but should create bugs or atleast notes about the 4(?) TODOs listed here

::: devtools/shared/heapsnapshot/census-tree-node.js
@@ +69,5 @@
> +  return `FRAME,${frame.functionDisplayName},${frame.source},${frame.line},${frame.column},${frame.asyncCause}`;
> +};
> +
> +/**
> + * TODO FITZGEN

TODO what?
Attachment #8677166 - Flags: review?(jsantell) → review+
(In reply to Jordan Santell [:jsantell] [@jsantell] from comment #2)
> lgtm, but should create bugs or atleast notes about the 4(?) TODOs listed
> here

Woops, just forgot to fill out the doc comments... >_<
https://hg.mozilla.org/mozilla-central/rev/e472a823244c
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 44
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.