Closed
Bug 1217281
Opened 8 years ago
Closed 8 years ago
Make buildbot-configs branch env dependent
Categories
(Release Engineering :: Release Automation: Other, defect)
Release Engineering
Release Automation: Other
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: rail, Assigned: rail)
References
Details
Attachments
(1 file)
4.91 KB,
patch
|
Callek
:
review+
rail
:
checked-in+
|
Details | Diff | Splinter Review |
Being able to use default branch of buildbot-configs is very convenient for dev.
Attachment #8677234 -
Flags: review?(bugspam.Callek)
Comment 1•8 years ago
|
||
Comment on attachment 8677234 [details] [diff] [review] devenv.diff Review of attachment 8677234 [details] [diff] [review]: ----------------------------------------------------------------- I'd be happier if the config base was used by default, but the env could just override it instead if desired. (e.g. if SeaMonkey ever makes a release-runner) but since ONLY moco even uses it, I see no actual harm in this approach.
Attachment #8677234 -
Flags: review?(bugspam.Callek) → review+
Assignee | ||
Comment 2•8 years ago
|
||
Comment on attachment 8677234 [details] [diff] [review] devenv.diff remote: https://hg.mozilla.org/build/puppet/rev/e028ab614b28 remote: https://hg.mozilla.org/build/puppet/rev/7b776477db2c
Attachment #8677234 -
Flags: checked-in+
Assignee | ||
Updated•8 years ago
|
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•