Closed Bug 1217281 Opened 6 years ago Closed 6 years ago

Make buildbot-configs branch env dependent

Categories

(Release Engineering :: Release Automation: Other, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: rail, Assigned: rail)

References

Details

Attachments

(1 file)

Attached patch devenv.diffSplinter Review
Being able to use default branch of buildbot-configs is very convenient for dev.
Attachment #8677234 - Flags: review?(bugspam.Callek)
Comment on attachment 8677234 [details] [diff] [review]
devenv.diff

Review of attachment 8677234 [details] [diff] [review]:
-----------------------------------------------------------------

I'd be happier if the config base was used by default, but the env could just override it instead if desired. (e.g. if SeaMonkey ever makes a release-runner) but since ONLY moco even uses it, I see no actual harm in this approach.
Attachment #8677234 - Flags: review?(bugspam.Callek) → review+
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.