1217283 - TryChooser should support using shift key to select a range of tests

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[Xidorn Quan [:xidorn] UTC+10]

I sometimes want to choose only part of tests in one column, e.g. mochitest-[1-5] or mochitest-e10s-[1-5]. They are continuous, but I have to select them one by one. It is even worse if I want to choose only the "Android-Only Unittest Suites" or "B2G-Only Unittest Suites".

I suggest if an item is clicked when the shift key is pressed, all items between the last checked box and the current box should be set to the new state of the current box.

For example, given the list below:
[ ] mochitest-1
[ ] mochitest-2
[ ] mochitest-3
[ ] mochitest-4
[ ] mochitest-5

If I click "mochitest-1", and then shift-click "mochitest-5", the result should be:
[X] mochitest-1
[X] mochitest-2
[X] mochitest-3
[X] mochitest-4
[X] mochitest-5

Then if I click "mochitest-2" and shift-click "mochitest-4", the result should be:
[X] mochitest-1
[ ] mochitest-2
[ ] mochitest-3
[ ] mochitest-4
[X] mochitest-5

It would be useful.

Comment 1

[Xidorn Quan [:xidorn] UTC+10]

Attachment: patch

Comment 2

[Xidorn Quan [:xidorn] UTC+10]

Ping on this patch?

Comment 3

[William Lachance (:wlach)]

Comment on attachment 8691239 [details] [diff] [review]
patch

Review of attachment 8691239 [details] [diff] [review]:
-----------------------------------------------------------------

(stealing this review on Callek's request)

This doesn't work much of the time for me.

Failure case:

Select "Linux" on platforms. Then click "None". Then click "Linux" again. Then shift click down 5 spots.

Expected:

All 5 platforms are selected

Actual: 

Nothing happens

In general the feature seems to work only intermittently for me on MacOS X, both Firefox and Chrome. But the above steps fail every time for me, so it seems like a place to start.

::: trychooser/trychooser.css
@@ +53,5 @@
>      cursor: pointer;
> +    -webkit-user-select: none;
> +    -moz-user-select: none;
> +    -ms-user-select: none;
> +    user-select: none;

This is somewhat non-standard, I guess there's no alternative?

Comment 4

[Xidorn Quan [:xidorn] UTC+10]

I don't understand why that doesn't work for you. It works perfectly for me every time including your steps, on both Windows and OS X, both Firefox and Chrome.

Comment 5

[Xidorn Quan [:xidorn] UTC+10]

Attachment: patch

OK, I guess you were trying to click on the checkboxs instead of the labels. This new patch should work on both cases.

Comment 6

[Xidorn Quan [:xidorn] UTC+10]

(In reply to William Lachance (:wlach) from comment #3)
> Comment on attachment 8691239 [details] [diff] [review]
> patch
> 
> Review of attachment 8691239 [details] [diff] [review]:
> -----------------------------------------------------------------
> ::: trychooser/trychooser.css
> @@ +53,5 @@
> >      cursor: pointer;
> > +    -webkit-user-select: none;
> > +    -moz-user-select: none;
> > +    -ms-user-select: none;
> > +    user-select: none;
> 
> This is somewhat non-standard, I guess there's no alternative?

This is on a standards track anyway, in CSS UI 4 draft.

Comment 7

[Xidorn Quan [:xidorn] UTC+10]

Attachment: patch

Fix some typos.

Comment 8

[William Lachance (:wlach)]

Comment on attachment 8700837 [details] [diff] [review]
patch

Review of attachment 8700837 [details] [diff] [review]:
-----------------------------------------------------------------

Oh sorry, I missed the part about having to click on the names. But I think being able to click on the names or the checkbox is better in any case! I'm sure this feature will be useful to many people.

Feel free to land this. I don't know the details of what we have to do to get the changes deployed, maybe Callek can chime in on that.

Comment 9

[Xidorn Quan [:xidorn] UTC+10]

https://hg.mozilla.org/build/tools/rev/fb1e1179e42b7dd25892e54105235bdd8adeb54f
Bug 1217283 - Add support for shift key to select a range. r=wlach

Comment 10

[Xidorn Quan [:xidorn] UTC+10]

I wonder whether I should close it now or close it until this change gets deployed.

Comment 11

[Justin Wood (:Callek)]

[2015-12-28 06:51:05] Finished push_www (9.454s)