Open Bug 1217397 Opened 6 years ago Updated 5 years ago

Having an IRC contact with a space in the nick breaks WATCH

Categories

(Chat Core :: IRC, defect)

defect
Not set
normal

Tracking

(Not tracked)

People

(Reporter: nhnt11, Unassigned)

Details

It errors out here: https://dxr.mozilla.org/comm-central/source/chat/protocols/irc/irc.js#1681.

Results in all IRC contacts having unknown status.

I'm not sure if the right fix is just to disallow adding contacts with spaces in the nick.

Error console errors:

Timestamp: 10/22/15, 5:31:04 PM
Error: IRC parameters cannot have spaces: +<nick with spaces>,+<nick1>,+<nick2>,+<nick3>
Source File: resource://gre/components/irc.js
Line: 1681
Source Code:
prpl-irc: ircAccount.prototype.buildMessage

Timestamp: 10/22/15, 5:31:04 PM
Error: Error running command 251 with handler WATCH:
{"rawMessage":":fripp.mozilla.org 251 nhnt11 :There are 3100 users and 873 invisible on 5 servers","command":"251","params":["nhnt11","There are 3100 users and 873 invisible on 5 servers"],"origin":"fripp.mozilla.org","tags":{},"source":""}
aMessage is null
Source File: resource://gre/components/irc.js
Line: 1713
Source Code:
prpl-irc: ircHandlers._handleMessage
How did you add a nick with a space?
Are nicks with spaces even in spec?
No, we should be rejecting them, if possible.
You need to log in before you can comment on or make changes to this bug.