1217458 - Fix the TODO comments in TelemetrySession.jsm to point to the correct bug

Status: RESOLVED FIXED

(Toolkit :: Telemetry, defect, P3)

Description

[Alessio Placitelli [:Dexter]]

We need to change the "TODO: Remove this when bug 1124128 lands" comments in TelemetrySession.jsm [1] to "TODO: Remove this when bug 1201837 lands", as bug 1124128  was closed.

[1] - https://dxr.mozilla.org/mozilla-central/rev/daa7d98525e859d32a3b3e97101e129a897192a1/toolkit/components/telemetry/TelemetrySession.jsm#1070

Comment 1

[Alessio Placitelli [:Dexter]]

The comments that need to be changed are:

- https://dxr.mozilla.org/mozilla-central/rev/7883e81f3c305078353ca27a6b1adb8c769d5904/toolkit/components/telemetry/TelemetrySession.jsm#972
- https://dxr.mozilla.org/mozilla-central/rev/7883e81f3c305078353ca27a6b1adb8c769d5904/toolkit/components/telemetry/TelemetrySession.jsm#976

To check that everything works correctly (even though we're only changing a comment), run the following command:

./mach xpcshell-test toolkit/components/telemetry

Comment 2

[Patrick]

Hi, I would be submitting a patch for this bug within the next few days. Would it be OK to assign this bug to me after patch submission please?

Comment 3

[Patrick]

Attachment: rev1 - Replace line of text

Replaced line as requested. Please check that everythuing is ok.

Comment 4

[Patrick]

Attachment: rev 2 - bug1217458_editTEXT2.diff

My first patch had a change in just #972 as i missed adding the changes in #976. The second patch covers both.

Comment 5

[Alessio Placitelli [:Dexter]]

(In reply to Patrick from comment #2)
> Hi, I would be submitting a patch for this bug within the next few days.
> Would it be OK to assign this bug to me after patch submission please?

Hi Patrick, welcome and thank you for submitting your first patches!

Do you mind merging them in a single patch file? Note that you can use the title of this bug as a commit message in the bug.

Once done, please attach the new patch and flag me for review!

Comment 6

[Patrick]

Hi Alessio. Sure I'll upload another patch soon.

Comment 7

[Patrick]

Attachment: bug1217458_editTEXT2.diff

Final Revision - Comment ammended.

Comment 8

[Alessio Placitelli [:Dexter]]

Comment on attachment 8696558 [details] [diff] [review]
bug1217458_editTEXT2.diff

Review of attachment 8696558 [details] [diff] [review]:
-----------------------------------------------------------------

We're almost there, thanks for the update. Could you change the commit message to "Bug 1217458: change TelemetrySession comments to point to the correct bug number.". Once done that, we'll land this patch!

Comment 9

[Patrick]

Attachment: bug1217458_editTEXT2.diff

I think that's everything. :)

Comment 10

[Alessio Placitelli [:Dexter]]

Comment on attachment 8696661 [details] [diff] [review]
bug1217458_editTEXT2.diff

Review of attachment 8696661 [details] [diff] [review]:
-----------------------------------------------------------------

This looks good now, thanks.

We can push that, as this only changes a comment.

Comment 11

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/565639d2a1b8

Comment 12

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/565639d2a1b8