1217485 - Make various methods in cards_view part of class Card instead of class CardsView

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::UI Tests, defect)

Description

[Martijn Wargers (dead)]

A lot of methods like tap_app(), wait_for_card_ready, close_app() should be part of class Card, I think, and not part of CardsView.

Comment 1

[GitHub Autolander Bot]

Attachment: [gaia] mwargers:1217485 > mozilla-b2g:master

Comment 2

[Martijn Wargers (dead)]

Comment on attachment 8678451 [details] [review]
[gaia] mwargers:1217485 > mozilla-b2g:master

Something like this.
This will break some mtbf tests:
https://github.com/Mozilla-TWQA/MTBF-Driver/blob/9f876e71491fd685dcb3a24e8f4b51d2cada0b54/mtbf_driver/tests/mtbf/cards_view/test_mtbf_cards_view_kill_apps_with_two_apps.py
https://github.com/Mozilla-TWQA/MTBF-Driver/blob/9f876e71491fd685dcb3a24e8f4b51d2cada0b54/mtbf_driver/tests/mtbf/cards_view/test_mtbf_cards_view_with_two_apps.py
So I guess we should get those updated as well, if this pull request would be checked in.

I couldn't find anything in Eli Perelman's performance tests: https://github.com/mozilla-raptor/raptor-cli/search?utf8=%E2%9C%93&q=cardsview

Also I couldn't find anything in Jon Hyland's power tests: https://github.com/JonHylands/power-tests/search?utf8=%E2%9C%93&q=cardsview

Comment 3

[Martijn Wargers (dead)]

Do we have more consumers of GaiaTest that I'm not aware of?

Comment 4

[No-Jun Park [:njpark]]

Comment on attachment 8678451 [details] [review]
[gaia] mwargers:1217485 > mozilla-b2g:master

Seem like a good cleanup, and the imagecompare tess pass reliably.

Comment 5

[Johan Lorenzo [:jlorenzo]]

Comment on attachment 8678451 [details] [review]
[gaia] mwargers:1217485 > mozilla-b2g:master

Good cleanup. There're some minor fixes we could do, but I won't block on them. More details in the PR.

Comment 6

[Martijn Wargers (dead)]

Ok, updated the pull request with the minor fixes in there.

I made a pull request for the change needed in mtbtf here: https://github.com/Mozilla-TWQA/MTBF-Driver/pull/114
Only test_mtbf_cards_view_kill_apps_with_two_apps.py needed to change. test_mtbf_cards_view_with_two_apps.py looks totally different, actually.

Walter, can you merge this MTBF pull request once the pull request in this bug lands?

Comment 7

[Martijn Wargers (dead)]

(In reply to Martijn Wargers [:mwargers] (QA) from comment #6)
> Walter, can you merge this MTBF pull request once the pull request in this
> bug lands?

Paul merged this, thanks Paul!

Merged the pull request in this bug: https://github.com/mozilla-b2g/gaia/commit/1175cde3c59d0de6c6ce7ee2cbadda6667e52e05