1217570 - Add a "Cancel all" option to the pinboard dropdown menu.

Status: RESOLVED FIXED

(Tree Management :: Treeherder, defect)

Description

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

If I pin multiple jobs to the pinboard, then click the 'v' next to the "Save" button, I can retrigger all of those jobs with a single click.

It'd be nice if I could pin a bunch of running/pending jobs and hit a similar "Cancel all" button to cancel all of the pinned jobs.

Comment 2

[Kartikaya Gupta (email:[e-mail])]

Also, adding a keyboard shortcut to cancel the selected job would be even better, since that cuts out an extra step.

Comment 3

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

(In reply to Kartikaya Gupta (email:[e-mail]) from comment #2)
> Also, adding a keyboard shortcut to cancel the selected job would be even
> better, since that cuts out an extra step.

I'd be hesitant to add a keyboard shortcut for it unless Treeherder does some prompt to confirm that you didn't just have a cat walk across your keyboard. Though maybe a prompt for any cancel request (with more than one selected job, perhaps) wouldn't be a bad thing, regardless of how the cancellation request was triggered?

Comment 5

[Kartikaya Gupta (email:[e-mail])]

Bump. Ran into a situation today where this would have been really useful, because jobs that I didn't ask for got scheduled on my try push after the infra problems earlier today.

Comment 6

[Kartikaya Gupta (email:[e-mail])]

Bump again. I would love to reduce the backlog of pending talos jobs on linux64 by canceling said jobs on the graphics branch. But canceling them one at a time is super painful.

Comment 7

[William Lachance (:wlach)]

(In reply to Kartikaya Gupta (email:[e-mail]) from comment #6)
> Bump again. I would love to reduce the backlog of pending talos jobs on
> linux64 by canceling said jobs on the graphics branch. But canceling them
> one at a time is super painful.

This is made a little more difficult than it should be by the fact that you need the buildbot request id to cancel buildbot jobs, and that needs to be explicitly downloaded at the moment (via the job details api)

You would need to do something like this here:

https://github.com/mozilla/treeherder/blob/5ec35f62d0f152688dcdd9ea346faed044e29dad/ui/plugins/controller.js#L185

Then actually cancel the jobs following the example here:

https://github.com/mozilla/treeherder/blob/5ec35f62d0f152688dcdd9ea346faed044e29dad/ui/plugins/controller.js#L432

Comment 8

[Kartikaya Gupta (email:[e-mail])]

If this is hard to implement in TH itself, is there a JS snippet I can paste into the web console that basically replicates the manual user action of "click cancel, press the right arrow on the keyboard"? For the purposes of killing pending talos jobs I just need to repeat this sequence 18 times so if I can do it in a for loop in the web console that would help a lot.

Comment 9

[William Lachance (:wlach)]

(In reply to Kartikaya Gupta (email:[e-mail]) from comment #8)
> If this is hard to implement in TH itself, is there a JS snippet I can paste
> into the web console that basically replicates the manual user action of
> "click cancel, press the right arrow on the keyboard"? For the purposes of
> killing pending talos jobs I just need to repeat this sequence 18 times so
> if I can do it in a for loop in the web console that would help a lot.

I can't think of an easy way to do this, though maybe I just lack imagination.

It really isn't that hard to implement this feature, just not trivial. I'll try to implement this during the afternoon (or at least within a week), I suspect the sheriffs would find this feature extremely useful as well.

Comment 10

[GitHub Autolander Bot]

Attachment: [treeherder] wlach:1217570 > mozilla:master

Comment 11

[William Lachance (:wlach)]

Comment on attachment 8830917 [details] [review]
[treeherder] wlach:1217570 > mozilla:master

Feel free to redirect to camd if you think he'd do better reviewing this. Also no rush, I'll be away next week and would rather be around when this lands.

Comment 12

[Treeherder GitHub Bugbot]

Commits pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/b7874f66f8178c927e446203f50391818623f2b6
Bug 1217570 - Allow filtering by job_id but not repo in jobdetail endpoint

When we had per-project db's this didn't make any sense, but now it does.

https://github.com/mozilla/treeherder/commit/b43d602272582bf3f656b7577b7fb2d9bcbfe32f
Bug 1217570 - Allow cancelling all selected jobs in pinboard

Comment 13

[GitHub Autolander Bot]

Attachment: [treeherder] wlach:1217570-followup > mozilla:master

Comment 14

[William Lachance (:wlach)]

Comment on attachment 8834406 [details] [review]
[treeherder] wlach:1217570-followup > mozilla:master

Quick followup per irc discussion

Comment 15

[Treeherder GitHub Bugbot]

Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/f8ce8e14d36480488691e33e3fc43bbf385a408e
Bug 1217570 - Confirm that user really wants to cancel all jobs in pinboard (#2141)

Comment 16

[Treeherder GitHub Bugbot]

Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/f9cd47c16bcd8a95c9ce722056104955cc1ac1a2
Bug 1217570 - Fix title of cancel all jobs option

Comment 17

[William Lachance (:wlach)]

(fixed a title in an unreviewed commit, it was a trivial change involving flipping a boolean)

I think we're good here now. Tested and wrote a blog post about the feature:

http://wlach.github.io/blog/2017/02/cancel-all-the-things/