Open Bug 1217670 Opened 9 years ago Updated 2 years ago

Improve NS_NewRunnableMethodWithArgs implementation

Categories

(Core :: XPCOM, defect)

44 Branch
defect

Tracking

()

Tracking Status
firefox44 --- affected

People

(Reporter: mozbugz, Unassigned)

References

Details

Note to self (or to whomever wants to tackle this).

The storage classes used by NS_NewRunnableMethodWithArgs are a bit clunky. In particular nsRunnableMethodArguments is a set of non-variadic templates (due to MSVC limitations at the time), they should be collapsed into one variadic template when possible.
There was an attempt in bug 1163320.

Remove "ns" from "StorensRefPtrPassByPtr".

Also, it would be interesting to see if the different "Store...PassBy..." classes could be refactored in some way, to simplify maintenance and reuse.

Finally, there should be a survey of current usage, to see if the automatic storage selection works as intended, and/or if different ones are needed.
Severity: normal → S3
You need to log in before you can comment on or make changes to this bug.