Status

RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: kgrandon, Assigned: kgrandon)

Tracking

Details

Attachments

(2 attachments)

(Assignee)

Description

3 years ago
Splitting this off from the user story. This is just the implementation for the very first page in the B2GDroid FTU.

Spec: https://mozilla.box.com/s/7lxne828wu3w87w319nsaxns73d03hcy
Created attachment 8677807 [details] [review]
[gaia] KevinGrandon:bug_1217674_b2gdroid_ftu > mozilla-b2g:master
(Assignee)

Comment 2

3 years ago
Comment on attachment 8677807 [details] [review]
[gaia] KevinGrandon:bug_1217674_b2gdroid_ftu > mozilla-b2g:master

This was previously reviewed in bug 1206781. Carrying review.
Attachment #8677807 - Flags: review+
(Assignee)

Comment 3

3 years ago
In master: https://github.com/mozilla-b2g/gaia/commit/7d4ccb61af554f8a7fba50fe9e97f7d02f7cbe34
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
Kevin, sorry for the change, but we decided on a last minute name change for B2GDroid.  We need to change the text in this screen to:

Welcome to the Firefox OS developer preview, 
an experimental Android app from Mozilla 
that lets you experience Firefox OS.

We would love for you to get involved 
in shaping the future of the Web.

To find out how, visit: 
https://www.mozilla.org/contribute
or just grab the source code:
https://github.com/mozilla-b2g/gaia
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Flags: needinfo?(kevingrandon)
Blocks: 1219032
Created attachment 8679805 [details] [review]
[gaia] KevinGrandon:bug_1217674_update_b2gdroid_text > mozilla-b2g:master
(Assignee)

Comment 6

3 years ago
Comment on attachment 8679805 [details] [review]
[gaia] KevinGrandon:bug_1217674_update_b2gdroid_text > mozilla-b2g:master

Stas - can I just get a quick check if I'm using l10n /w links in the correct manner here? Thanks!
Flags: needinfo?(kevingrandon)
Attachment #8679805 - Flags: feedback?(stas)
Comment on attachment 8679805 [details] [review]
[gaia] KevinGrandon:bug_1217674_update_b2gdroid_text > mozilla-b2g:master

Yes! Thanks for asking, this is exactly right. The identity of the <a> elements will be preserved so event listeners will work fine.  The class and href attributes will also be kept.

One of the limitations of the current implementation is that the localizer can't reorder elements of the same type in the translation;  the attributes would get mixed up.  Perhaps to be on the safe side we could add a comment asking the localizers to keep the order of links the same as it is in en-US?
Attachment #8679805 - Flags: feedback?(stas) → feedback+
(Assignee)

Comment 8

3 years ago
Comment on attachment 8679805 [details] [review]
[gaia] KevinGrandon:bug_1217674_update_b2gdroid_text > mozilla-b2g:master

Thanks Stas. I think your feedback is enough here, so I'll review stamp this.

I've also added a localization note to not mix the order up.
Attachment #8679805 - Flags: review+
(Assignee)

Comment 9

3 years ago
Updates in master: https://github.com/mozilla-b2g/gaia/commit/b7f93d8430830e9b5f3ea3647c01680efd2dfb16
Status: REOPENED → RESOLVED
Last Resolved: 3 years ago3 years ago
Resolution: --- → FIXED
Thanks Kevin!
You need to log in before you can comment on or make changes to this bug.