1217777 - [RTL][Music]No song is matched with the keywords, the prompt message is center-aligned.

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Music, defect, P2)

Description

[Lancy(Leave from Mozilla)]

Attachment: Music_Search_Prompt message_v2.5.png

[1.Description]:
[RTL][FlameKK&AriesKK v2.5][Music]No song is matched with the keywords, the prompt message is center-aligned.
See attachments:Music_Search_Prompt message_v2.5.png.

[2.Testing Steps]: 
1. Have your phone set in a RTL language(Arabic) 
2. Go to the Music app with about 5~10 songs in the phone 
3. Go to the titles, Playlist, Artists, Albums or Songs view and tap the search field.
4. Input the keywords and no song is matched with the keywords.


[3.Expected Result]: 
4.The prompt message should be right-aligned.

[4.Actual Result]: 
4. The prompt message is center-aligned.

[5.Reproduction build]: 
Device: Flame KK 2.5 build (Affected)
Build ID               20151022150207
Gaia Revision          29ce8ec8606e59f582375234440812b046346513
Gaia Date              2015-10-22 05:31:38
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/76bd0c01d72e64ca4f261ffdb2652a91f961e930
Gecko Version          44.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20151022.185000
Firmware Date          Thu Oct 22 18:50:13 EDT 2015
Firmware Version       v18D v4
Bootloader             L1TC000118D0

Device: Aries KK 2.5 build (Affected)
Build ID               20151023005002
Gaia Revision          29ce8ec8606e59f582375234440812b046346513
Gaia Date              2015-10-22 05:31:38
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/1f03a14106e59280761ac53904340f389674337f
Gecko Version          44.0a1
Device Name            aries
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.worker.20151023.001128
Firmware Date          Fri Oct 23 00:11:35 UTC 2015
Bootloader             s1

[6.Reproduction Frequency]: 
Always Recurrence,10/10

[7.TCID]: 
15337

Comment 1

[Augustin Trancart [:autra]]

I's actually a Music issue.

Comment 2

[Wilson Page [:wilsonpage]]

This looks like the padding reserved for images is messing with the text alignment. I think the Music app will need to either:

A. Not use fast-list items to display the 'No results found' message.
B. Override the default list-item styling padding when rendering the 'no results found' state.

--- 

I think A sounds more sensible.

Comment 3

[GitHub Autolander Bot]

Attachment: [gaia] wilsonpage:1217777 > mozilla-b2g:master

Comment 4

[Justin D'Arcangelo [:justindarc]]

Comment on attachment 8688470 [details] [review]
[gaia] wilsonpage:1217777 > mozilla-b2g:master

LGTM

Comment 5

[Wilson Page [:wilsonpage]]

Comment on attachment 8688470 [details] [review]
[gaia] wilsonpage:1217777 > mozilla-b2g:master

https://github.com/mozilla-b2g/gaia/commit/666d9cddfaeef2682d4307877a06914a7ed43a4b

Comment 6

[Sharon]

This bug has been verified as "pass" on the latest build of Aries KK master and Flame KK master 512mb by the STR in comment 0 .

Actual result: No song is matched with the keywords,the prompt message is right-aligned.
See attachment: Verified_Aries_KK_master-Flame_KK_master.png
Reproduce rate: 0/10.

Device: Aries KK master( Pass )
Build ID               20151124014704
Gaia Revision          ea673b5c4cc19c3daca072691a659c68e4c6937f
Gaia Date              2015-11-23 16:41:08
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/19d89caa664dd9309c796929225ee409df5d1ee4
Gecko Version          45.0a1
Device Name            aries
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.worker.20151124.005529
Firmware Date          Tue Nov 24 00:55:36 UTC 2015
Bootloader             s1

Device: Flame KK master 512mb( Pass )
Build ID               20151124013632
Gaia Revision          ea673b5c4cc19c3daca072691a659c68e4c6937f
Gaia Date              2015-11-23 16:41:08
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/19d89caa664dd9309c796929225ee409df5d1ee4
Gecko Version          45.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.worker.20151124.005539
Firmware Date          Tue Nov 24 00:55:49 UTC 2015
Bootloader             L1TC000118D0

Comment 7

[Sharon]

Attachment: Verified_Aries_KK_master-Flame_KK_master.png

Comment 8

[Wilson Page [:wilsonpage]]

Comment on attachment 8688470 [details] [review]
[gaia] wilsonpage:1217777 > mozilla-b2g:master

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #):
[User impact] if declined: UI looks a bit broken
[Testing completed]: Y
[Risk to taking this patch] (and alternatives if risky): Low
[String changes made]: N

Comment 9

[Mahendra Potharaju [:mahe]]

Comment on attachment 8688470 [details] [review]
[gaia] wilsonpage:1217777 > mozilla-b2g:master

Paper cut. Not a must have on 2.5. Getting 2.5 stable for TV, so removing from 2.5 uplift queue. 

Thanks

Comment 10

[Jim Porter (:squib)]

The Music app doesn't exist on TVs, so I don't see how TV stability affects this bug one way or the other.

Comment 11

[Mahendra Potharaju [:mahe]]

Comment on attachment 8688470 [details] [review]
[gaia] wilsonpage:1217777 > mozilla-b2g:master

Approved for 2.5

Comment 12

[Carsten Book [:Tomcat]]

for 2.5 https://github.com/mozilla-b2g/gaia/commit/699946d7997ecd4e6fbbb6cfba86646a2cf0f48f