1217827 - Enable MOZ_WEBRTC for Firefox OS on aarch64

Status: RESOLVED FIXED

(Firefox OS Graveyard :: GonkIntegration, defect)

Description

[Adam Farden [:adfad666]]

User Agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/46.0.2490.80 Safari/537.36

Comment 1

[Adam Farden [:adfad666]]

Attachment: Gecko Patch

We need this or we hit this condition: https://github.com/mozilla/gecko-dev/blob/master/media/libvpx/moz.build#L67

Which is an error because `cpu-features.c` no longer exists.

Whatever it was originally used for is probably redundant, and can be removed as it was removed from the Android NDK 4 years ago.

Comment 2

[[:fabrice] Fabrice Desré]

Comment on attachment 8678109 [details] [diff] [review]
Gecko Patch

Review of attachment 8678109 [details] [diff] [review]:
-----------------------------------------------------------------

Looks fine to me but you need a build peer review for changes to configure.in

Comment 3

[Mike Hommey [:glandium]]

Comment on attachment 8678109 [details] [diff] [review]
Gecko Patch

Review of attachment 8678109 [details] [diff] [review]:
-----------------------------------------------------------------

We don't put Signed-off-by lines in commit messages.

I'm tempted to say this is incomplete. That is, I don't see a reason not to enable webrtc on aarch64. But it isn't related to the specific reasons you are giving in the commit message. In fact, I'd argue you should actually fix the webrtc-disabled case as well.

Comment 4

[Adam Farden [:adfad666]]

Actually I misinterpreted the error. Here it is in full:

    File listed in SOURCES does not exist: '/home/adfad666/B2G/gecko/home/adfad666/B2G/ndk/sources/android/cpufeatures/cpu-features.c'

The file _does_ exist, but the path is invalid.

I'll update the commit message and open a new bug for this.

Comment 5

[Adam Farden [:adfad666]]

Attachment: Gecko Patch

No change to patch, only updated the commit message.

Bug 1218702 created for NDK path bug.

Comment 6

[Pulsebot]

https://hg.mozilla.org/integration/b2g-inbound/rev/87939d690491

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/87939d690491

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/87939d690491

Comment 9

[Carsten Book [:Tomcat]]

removing the b2g 2.5 flag since this commit has been reverted due to an incorrect merge, sorry for the confusion