1217882 - attachment.cgi?action=enter fails if FlagTypeComments extension is enabled and no flags have been configured yet

Status: NEW

(bugzilla.mozilla.org :: Extensions, defect)

Description

[David Lawrence [:dkl]]

DBD::mysql::db selectall_arrayref failed: You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near ') AND on_status IN ('?','+','-')' at line 3 [for Statement "SELECT type_id AS flagtype, on_status AS state, comment AS text FROM flagtype_comments WHERE type_id IN () AND on_status IN ('?','+','-')"]

Comment 1

[Dave Miller [:justdave]]

Attachment: GitHub Pull Request - Harmony branch - by https://github.com/userid0x0

Comment 2

[:glob ✱]

justdave, are you planning on landing this onto BMO as well as harmony?

If so, please raise as PR against mozilla-bteam/bmo.
If not, we'd want to have two bugs to track the separate landings.

Thanks!

Comment 3

[Dave Miller [:justdave]]

I just posted on the PR requesting the submitter to also submit the PR to the BMO repo then link it here.

I don't think I have permission to land anything on BMO, but you have my approval to merge the PR to harmony at the same time.

Comment 4

[Dave Miller [:justdave]]

Well, I didn't intend to land this yet, but our branch merge settings were apparently screwed up on the harmony repo, and so something I expected to have a confirmation dialog didn't, and it's now landed on harmony:

To github.com:bugzilla/harmony.git

• 2d73fd65c...60c3e6495 main -> main

I'll leave this open until we handle the BMO merge, assuming it happens in the next day or two.

Comment 5

[:glob ✱]

(In reply to Dave Miller [:justdave] from comment #3)

I just posted on the PR requesting the submitter to also submit the PR to the BMO repo then link it here.

Great, thanks.

If dkl wants to cherry-pick the trivial fix he can land it too (I don't have permissions to push to the BMO repo either).