1217928 - [New Homescreen] Homescreen App order is not preserved during OTA when moving to the New Home Screen

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Homescreen, defect)

Description

[Martin Shuman [:Marty]]

Attachment: logcat_OTA-Homescreen.txt

Description:
The order of the apps is not preserved during the transition from the old home screen to the new home screen during the OTA process.

Per Email conversation with Chris Lord, the app order is supposed to be imported during the OTA process.

Repro Steps:
1) Update a Aries to 20150619225606
2) Arrange the Apps on the Homescreen to a unique configuration.
3) Run an OTA update to build 20151023104059
4) Check the app order on the Homescreen and compare it to the homescreen app order before the update

Actual:
Homescreen app order is not preserved during the OTA process, and is reset to default with user installed apps and bookmarks at the bottom.

Expected:
Homescreen app order is the same before and after the OTA process.

Environmental Variables:
Device: Aries 2.5
Build ID: 20151023104059
Gaia: 410e91ddabc7ba82a9b43b3711a3fdf2cb8de309
Gecko: 0625c68c0abcfe4d10880d15d8fe7d06df3369c9
Gonk: 2916e2368074b5383c80bf5a0fba3fc83ba310bd
Version: 44.0a1 (2.5)
Firmware Version: D5803_23.1.A.1.28_NCB.ftf
User Agent: Mozilla/5.0 (Mobile; rv:44.0) Gecko/44.0 Firefox/44.0

Repro frequency: 5/5
See attached: Screenshots, Logcat

Comment 1

[Martin Shuman [:Marty]]

Attachment: Homescreen-Before-After-OTA-Screenshot.png

Comment 2

[Martin Shuman [:Marty]]

This issue does occur on Flame 2.5 builds.
Homescreen app order is not preserved during the OTA process, and is reset to default with user installed apps and bookmarks at the bottom.

Environmental Variables:
Device: Flame 2.5
BuildID: 20151022144730
Gaia: 32d827a70af90a05918f234e5b16b35d5d2a07e8
Gecko: 894a28d90bcdf0c845b9c47d4a36fc6e0815d2b1
Gonk: 205ac4204bbbb2098a8046444acba551ba5dc75a
Version: 44.0a1 (2.5) 
Firmware Version: v18D
User Agent: Mozilla/5.0 (Mobile; rv:44.0) Gecko/44.0 Firefox/44.0

Comment 3

[Chris Lord [:cwiiis]]

Martin, could you help me with steps on building and flashing an OTA? This isn't something I know how to do, so currently I have no way of debugging/fixing this issue.

For reference, I build my own images from a B2G tree, so I'm at least that far.

Comment 4

[Martin Shuman [:Marty]]

In order to see this issue, you have to run an OTA from an older build, which still had the old Home Screen as the default. For example, build 20151007142909.

If you want to update to a specific build or channel, you can change the update channel and URL at the bottom of the Developer settings menu, otherwise, it will probably be easiest to set the update channel to 'dogfood-latest' then go to the Device Information and select 'Check for updates'. Once the device finds an update, a notification will appear at the top of the screen, and you can install the update from the Utility Tray.

Comment 5

[Chris Lord [:cwiiis]]

(In reply to Martin Shuman [:Marty] from comment #4)
> In order to see this issue, you have to run an OTA from an older build,
> which still had the old Home Screen as the default. For example, build
> 20151007142909.
> 
> If you want to update to a specific build or channel, you can change the
> update channel and URL at the bottom of the Developer settings menu,
> otherwise, it will probably be easiest to set the update channel to
> 'dogfood-latest' then go to the Device Information and select 'Check for
> updates'. Once the device finds an update, a notification will appear at the
> top of the screen, and you can install the update from the Utility Tray.

This is not a reasonable way to debug this problem, given I have other things that require attention. Hopefully we can come back to this when things are less busy, or alternatively, if someone can inform me of how to either build and trigger an OTA update myself, or to simulate one, I'll get back onto this.

Comment 6

[KTucker [:KTucker][Inactive 3/4/2016]]

Naoki, can you help out here?

Comment 7

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Wait, we're going from an old homescreen to a new homescreen?
I don't think it's expected to preserve the order from old to new is it?

I mean we're switching homescreens at the same time as OTAing.  The new homescreen would have to accommodate the old homescreen's order is basically what it boils down to...  Is that even possible, Chris?

Comment 8

[Chris Lord [:cwiiis]]

(In reply to Naoki Hirata :nhirata (please use needinfo instead of cc) from comment #7)
> Wait, we're going from an old homescreen to a new homescreen?
> I don't think it's expected to preserve the order from old to new is it?
> 
> I mean we're switching homescreens at the same time as OTAing.  The new
> homescreen would have to accommodate the old homescreen's order is basically
> what it boils down to...  Is that even possible, Chris?

Argh sorry, thought I'd replied to this - Yes, we should migrate app icon order, there's code that specifically does this (bug 1202422) and a marionette test that covers it, although this test is obviously not testing in a useful way wrt to OTA...

I think it's probably too late to block on this, but if anyone can get me some way of being able to test this quickly, I could probably get a fix in.

Comment 9

[Chris Lord [:cwiiis]]

This should be fixed now I believe (with bug 1220311), just need QA to verify.

Comment 10

[zouyi(Leave from Mozilla)]

This bug can not be repro on Aries KK master after updating build from 2015-12-03 to 2015-12-23, so I close this bug, if anyone can repro it, please reopen again.

Occurrence rate: 0/3

Actual result: Homescreen app order is the same before and after the OTA process.
 
Device: Aries KK master(Unaffected)
Build ID               20151203001523
Gaia Revision          719d89803fd1809bb1132e564a6d0c255963d4b7
Gaia Date              2015-12-02 09:58:12
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/eec9a0bfd929a68237f0ef799a9d8f28c4749296
Gecko Version          45.0a1
Device Name            aries
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.worker.20151202.233158
Firmware Date          Wed Dec  2 23:32:06 UTC 2015
Bootloader             s1

Comment 11

[zouyi(Leave from Mozilla)]

This bug has been verified as pass on latest build of Aries KK master by the STR in comment 0.
Actual results: Homescreen app order is the same before and after the OTA process.
See attachment: verified Aries_kk master.3gp
Reproduce rate: 0/4

Device: Aries KK master(Pass)
Build ID               20151203001523
Gaia Revision          719d89803fd1809bb1132e564a6d0c255963d4b7
Gaia Date              2015-12-02 09:58:12
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/eec9a0bfd929a68237f0ef799a9d8f28c4749296
Gecko Version          45.0a1
Device Name            aries
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.worker.20151202.233158
Firmware Date          Wed Dec  2 23:32:06 UTC 2015
Bootloader             s1

Comment 12

[zouyi(Leave from Mozilla)]

Note: 
Aries v2.5 & Flame v2.5: The OTA sever is not ready for v2.5 channel.
Flame master: The device will go to recovery mode in Flame master OTA. 
We will verify the builds above once they are ready.

Comment 13

[zouyi(Leave from Mozilla)]

Attachment: verified Aries_kk master.3gp

Comment 14

[Martin Shuman [:Marty]]

This issue is still occurring on the latest Aries and Flame 2.6 builds.
If the user has a custom app order on the Legacy Homescreen, that app order will not be properly migrated to the New Homescreen during the OTA process.  The New Homescreen will display the default app order, not the user configured custom app order.

Aries was updated from build 20151001114357 to the latest Dogfood build .
Flame was updated from the v18D v4 Base Image to the latest Nightly build.

Environmental Variables:
Device: Aries 2.6
BuildID: 20160104105544
Gaia: 765d98a20f903ed34b91814e1ad0ce4181fba548
Gecko: 0771c5eab32f0cee4f7d12bc382298a81e0eabb2
Gonk: 2916e2368074b5383c80bf5a0fba3fc83ba310bd
Version: 46.0a1 (2.6) 
Firmware Version: D5803_23.1.A.1.28_NCB.ftf
User Agent: Mozilla/5.0 (Mobile; rv:46.0) Gecko/46.0 Firefox/46.0

Environmental Variables:
Device: Flame 2.6
BuildID: 20160104030207
Gaia: 765d98a20f903ed34b91814e1ad0ce4181fba548
Gecko: 0771c5eab32f0cee4f7d12bc382298a81e0eabb2
Gonk: 040bb1e9ac8a5b6dd756fdd696aa37a8868b5c67
Version: 46.0a1 (2.6) 
Firmware Version: v18D
User Agent: Mozilla/5.0 (Mobile; rv:46.0) Gecko/46.0 Firefox/46.0

Comment 15

[KTucker [:KTucker][Inactive 3/4/2016]]

Chris, could you please elaborate on what the intention of the fix was? Should legacy home screen order be preserved after an OTA? If so this issue is still open. When otaing from new home screen to new home screen, the app order is preserved.

Comment 16

[Chris Lord [:cwiiis]]

(In reply to KTucker [:KTucker][Inactive 3/4/2016] from comment #15)
> Chris, could you please elaborate on what the intention of the fix was?
> Should legacy home screen order be preserved after an OTA? If so this issue
> is still open. When otaing from new home screen to new home screen, the app
> order is preserved.

The intension is that the app order from verticalhome be retained in new homescreen when upgrading via OTA. I'm guessing getting this to work is not a priority now - if it still doesn't, feel free to open a new bug about it, but I'm going to need solid STR and a way of building and flashing OTAs if I'm going to fix it.