1217944 - Wildcards don't work in web_accessible_resources

Status: VERIFIED FIXED

(WebExtensions :: Untriaged, defect)

Description

[Will Bamberg [:wbamberg]]

Attachment: froggify.xpi

I've attached a WebExtension that adds a button to the toolbar: click the button, it injects a content script that replaces images in the page with a picture of a frog.

The frog pic needs to be web accessible. I'm using a wildcard for its manifest.json entry:

  "web_accessible_resources": [
    "beasts/*.jpg"
  ]

Pressing the button yields: no frogs, and a security error in the console. If you change the manifest.json entry to list the file:

  "web_accessible_resources": [
    "beasts/frog.jpg"
  ]

...then it works as expected.

Comment 1

[Wilson Page [:wilsonpage]]

For reference: https://developer.chrome.com/extensions/manifest/web_accessible_resources

Comment 2

[Jesper Kristensen]

In Chrome I can expose web accessible resources that take query string parameters.

For example this content script:

    var iframe = document.createElement("iframe");
    iframe.src = chrome.extension.getURL("ui.html") + "?param=xyz";
    document.body.appendChild(iframe);

Will this be possible in Firefox soon?

Comment 3

[Kris Maglione [:kmag]]

(In reply to Jesper Kristensen from comment #2)
> Will this be possible in Firefox soon?

See bug 1247081.

Comment 4

[Andrew Swan [:aswan]]

Attachment: MozReview Request: Bug 1217944 Part 1 Make MatchGlobs work on arbitrary strings r?kmag

Review commit: https://reviewboard.mozilla.org/r/44667/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/44667/

Comment 5

[Andrew Swan [:aswan]]

Attachment: MozReview Request: Bug 1217944 Part 2 Support wildcards in web_accessible_resources r?kmag

Review commit: https://reviewboard.mozilla.org/r/44669/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/44669/

Comment 6

[Kris Maglione [:kmag]]

Comment on attachment 8738717 [details]
MozReview Request: Bug 1217944 Part 1 Make MatchGlobs work on arbitrary strings r?kmag

https://reviewboard.mozilla.org/r/44667/#review41417

Comment 7

[Kris Maglione [:kmag]]

Comment on attachment 8738718 [details]
MozReview Request: Bug 1217944 Part 2 Support wildcards in web_accessible_resources r?kmag

https://reviewboard.mozilla.org/r/44669/#review41419

Comment 8

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/4cdbb38c78e6
https://hg.mozilla.org/integration/fx-team/rev/f35e7953e89f

Comment 9

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/4cdbb38c78e6
https://hg.mozilla.org/mozilla-central/rev/f35e7953e89f

Comment 10

[CosminB]

I could reproduce this issue on Firefox 44.0a1 (20151023030245).
This issue is verified as fixed on Firefox unbranded build 48.0a1 (20160408030212) and Firefox 51.0a1 (2016-09-12), I can confirm that the images in the page are replaced with a picture of a frog.