Closed Bug 1217985 Opened 4 years ago Closed 4 years ago

Don't depend on Windows crypto DLLs if not building the Windows Maintenance Service

Categories

(Toolkit :: Application Update, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla44
Tracking Status
firefox44 --- fixed

People

(Reporter: arthur, Assigned: arthur)

References

(Blocks 1 open bug)

Details

(Whiteboard: [tor])

Attachments

(2 files)

In Tor Browser, a patch was introduced to avoid a dependency
on crypt32.dll and wintrust.dll when Windows Maintenance Service is not being built.

Here is a link that tracks the latest version of the Tor Browser patch:
https://torpat.ch/16906
(In reply to Arthur Edelstein from comment #0)

> https://torpat.ch/16906

To clarify: only the a2ebb7e patch will be need for this bug.

(The other patch has already landed in https://hg.mozilla.org/mozilla-central/rev/34bbc3cb3e79.)
Whiteboard: [tor]
Here is Tor Browser's patch rebased to the latest version of mozilla-central.
Attachment #8678401 - Flags: review?(robert.strong.bugs)
Assignee: nobody → arthuredelstein
Component: Build Config → Application Update
Product: Core → Toolkit
Comment on attachment 8678401 [details] [diff] [review]
0001-Don-t-depend-on-Windows-crypto-DLLs.patch

Looks fine and thanks!
Attachment #8678401 - Flags: review?(robert.strong.bugs) → review+
https://hg.mozilla.org/mozilla-central/rev/c4aebb4abcc5
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla44
> TestAUSHelper.obj : error LNK2019: unresolved external symbol "unsigned long __cdecl VerifyCertificateTrustForFile(wchar_t const *)" (?VerifyCertificateTrustForFile@@YAKPB_W@Z) referenced in function _wmain
> TestAUSHelper.exe : fatal error LNK1120: 1 unresolved externals
> c:/t1/hg/comm-central/mozilla/config/rules.mk:739: recipe for target 'TestAUSHelper.exe' failed
> mozmake[3]: *** [TestAUSHelper.exe] Error 1120
> mozmake[3]: Leaving directory 'c:/t1/hg/objdir-sm/toolkit/mozapps/update/tests'
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Is this the correct fix?
Flags: needinfo?(robert.strong.bugs)
Attachment #8680063 - Flags: feedback?(robert.strong.bugs)
Comment on attachment 8680063 [details] [diff] [review]
Proposed bustage fix

I believe that should be enough.

Are you ok with me landing this?
Flags: needinfo?(robert.strong.bugs)
Attachment #8680063 - Flags: feedback?(robert.strong.bugs) → feedback+
Sorry for the bustage -- thanks for fixing it.
https://hg.mozilla.org/mozilla-central/rev/22394f125cb5
Status: REOPENED → RESOLVED
Closed: 4 years ago4 years ago
Resolution: --- → FIXED
Blocks: meta_tor
You need to log in before you can comment on or make changes to this bug.