Closed Bug 1217985 Opened 4 years ago Closed 4 years ago
Don't depend on Windows crypto DLLs if not building the Windows Maintenance Service
In Tor Browser, a patch was introduced to avoid a dependency on crypt32.dll and wintrust.dll when Windows Maintenance Service is not being built. Here is a link that tracks the latest version of the Tor Browser patch: https://torpat.ch/16906
(In reply to Arthur Edelstein from comment #0) > https://torpat.ch/16906 To clarify: only the a2ebb7e patch will be need for this bug. (The other patch has already landed in https://hg.mozilla.org/mozilla-central/rev/34bbc3cb3e79.)
Here is Tor Browser's patch rebased to the latest version of mozilla-central.
Attachment #8678401 - Flags: review?(robert.strong.bugs)
Assignee: nobody → arthuredelstein
Component: Build Config → Application Update
Product: Core → Toolkit
Comment on attachment 8678401 [details] [diff] [review] 0001-Don-t-depend-on-Windows-crypto-DLLs.patch Looks fine and thanks!
Attachment #8678401 - Flags: review?(robert.strong.bugs) → review+
I also sent it to try and it looks good https://treeherder.mozilla.org/#/jobs?repo=try&revision=e7174020d6a9
Pushed to fx-team https://hg.mozilla.org/integration/fx-team/rev/c4aebb4abcc5
> TestAUSHelper.obj : error LNK2019: unresolved external symbol "unsigned long __cdecl VerifyCertificateTrustForFile(wchar_t const *)" (?VerifyCertificateTrustForFile@@YAKPB_W@Z) referenced in function _wmain > TestAUSHelper.exe : fatal error LNK1120: 1 unresolved externals > c:/t1/hg/comm-central/mozilla/config/rules.mk:739: recipe for target 'TestAUSHelper.exe' failed > mozmake: *** [TestAUSHelper.exe] Error 1120 > mozmake: Leaving directory 'c:/t1/hg/objdir-sm/toolkit/mozapps/update/tests'
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Is this the correct fix?
Attachment #8680063 - Flags: feedback?(robert.strong.bugs)
Comment on attachment 8680063 [details] [diff] [review] Proposed bustage fix I believe that should be enough. Are you ok with me landing this?
Attachment #8680063 - Flags: feedback?(robert.strong.bugs) → feedback+
Attachment #8680063 - Flags: review+
Sorry for the bustage -- thanks for fixing it.
Status: REOPENED → RESOLVED
Closed: 4 years ago → 4 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.