1218063 - Imagecompare: go_back_and_exit() method in header.py does not work in RTL

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::UI Tests, defect)

Description

[No-Jun Park [:njpark]]

Because it works by the coordinates, it won't work in RTL since the coordinate is reversed.  It looks like we no longer need this method, since we can locate elements under shadow DOM now.

Comment 1

[GitHub Autolander Bot]

Attachment: [gaia] npark-mozilla:1218063 > mozilla-b2g:master

Comment 2

[No-Jun Park [:njpark]]

Comment on attachment 8678428 [details] [review]
[gaia] npark-mozilla:1218063 > mozilla-b2g:master

This was failing the RTL test, since they recently reverse the coordinate system.  Also, i realized I can combine two methods into one.

Comment 3

[Martijn Wargers (dead)]

Comment on attachment 8678428 [details] [review]
[gaia] npark-mozilla:1218063 > mozilla-b2g:master

What happens if you add time.sleep(1) between "if exit_app:" and "app.wait_to_not_be_displayed"?
I think you get the errors as mentioned at: http://mxr.mozilla.org/gaia/source/tests/python/gaia-ui-tests/gaiatest/apps/base.py#100

For the rest, this looks like a good idea to me, we should make sure that the back button is tapped upon from the system app, though, I think.

Comment 4

[No-Jun Park [:njpark]]

Actually, I did check whether it causes NoSuchWindowException, and in this case it does not happen.  Probably because everything I do afterwards does not involve root_elements.  If I exit the app, the context is switched, so running Wait(self.marionette).until(expected.element_not_displayed(self.root_element)) will cause NoSuchWindowException, but not when I check the app itself.

Comment 5

[No-Jun Park [:njpark]]

Comment on attachment 8678428 [details] [review]
[gaia] npark-mozilla:1218063 > mozilla-b2g:master

I just verified that adding sleep calls do not cause failures

Comment 6

[Martijn Wargers (dead)]

Attachment: failure.txt

I get the failure in the attachment with this pull request applied and adding this to the code:

--- a/tests/python/gaia-ui-tests/gaiatest/form_controls/header.py
+++ b/tests/python/gaia-ui-tests/gaiatest/form_controls/header.py
@@ -23,7 +23,10 @@ class GaiaHeader(Widget):
             self.marionette.switch_to_shadow_root()
             self.root_element.find_element(*self._close_button_locator).tap()
         if exit_app:
+            import time
+            time.sleep(2)
             app.wait_to_not_be_displayed()
+            print(self.apps.displayed_app.manifest_url)
             self.apps.switch_to_displayed_app()

That failure is exactly what happens in bug 1109213.

Comment 7

[No-Jun Park [:njpark]]

I just updated my pull request, I double checked that entire script passes on both LTR and RTL.

Comment 8

[Martijn Wargers (dead)]

Comment on attachment 8678428 [details] [review]
[gaia] npark-mozilla:1218063 > mozilla-b2g:master

You also need to change this instance:
http://mxr.mozilla.org/gaia/source/tests/python/gaia-ui-tests/gaiatest/apps/gallery/regions/view_image.py#40
I guess the following self.apps.switch_to_displayed_app() line can be removed.

Also, I think this line:
http://mxr.mozilla.org/gaia/source/tests/python/gaia-ui-tests/gaiatest/tests/graphics/RTL/test_settings_personalization_RTL.py#30
settings.switch_to_settings_app() can be removed, since that's already done in the go_back call.
Also on line 40 and line 54, I think it can be removed.

Comment 9

[No-Jun Park [:njpark]]

I made above suggestions, plus the check for the shadow root so it doesn't do unnecessary self.marionette.switch_to_shadow_root()call.


Merged:
https://github.com/mozilla-b2g/gaia/commit/b564b21e08ffc3e4962f08850843c7482932ee7b

Comment 10

[Martijn Wargers (dead)]

Great!