1218068 - Firefox failing to retain full data for tabs not loaded during a session

Status: RESOLVED WORKSFORME

(Firefox :: Session Restore, defect)

Description

[aroskuski]

User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:41.0) Gecko/20100101 Firefox/41.0
Build ID: 20151016093648

Steps to reproduce:

1. Set Firefox  to "Show my windows and tabs from last time" and "Don't load tabs until selected".

2. Open some tabs, navigate to arbitrary web pages, and scroll around and type some data into forms, then close Firefox.

3. Open Firefox, wait for the currently selected tab to load, then immediately close it again without doing anything else.

4. Open Firefox again, and check the status of all of the tabs.


Actual results:

Details like scroll position and entered form data were lost for tabs which were not loaded when Firefox was started in step 3.

This is a regression from how Firefox acted before version 41.


Expected results:

The scroll position, entered form data, etc. should have been properly restored for all tabs.

Comment 1

[ovidiu boca[:Ovidiu]]

I can reproduce this bug on Ubuntu 14.04 with FF version 41.

I tested on FF version 40.0.2 and the bug can't be reproduce. This is a regression. 

Steps to reproduce:
1. Set Firefox  to "Show my windows and tabs from last time" and "Don't load tabs until selected".
2. Open some tabs, navigate to some web pages, and scroll around and type some data into forms, then close Firefox.
3. Open Firefox, wait for the currently selected tab to load expect at least 5 seconds, then immediately close it again without doing anything else.
4. Open Firefox and check the status of all of the tabs.


Actual results:

 Entered form data were lost for tabs which were not loaded when Firefox was started in step 3.

Expected results:

Entered form data should have been restored in all tabs.

Comment 2

[aroskuski]

I was still able to reproduce this bug with Firefox 42.  I also found that it seems to occur on Windows 10, as well.

Comment 3

[ovidiu boca[:Ovidiu]]

Regression range

https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=9e89159cbe385d31bd3876515ffdcfff5544571b&tochange=9f6b6dd5134cf3cb0f372f815fa40a5ab6a2425a

Comment 4

[aroskuski]

This issue can still be reproduced in Firefox 43.

Comment 5

[aroskuski]

(In reply to ovidiu boca from comment #3)
> Regression range
> 
> https://hg.mozilla.org/integration/mozilla-inbound/
> pushloghtml?fromchange=9e89159cbe385d31bd3876515ffdcfff5544571b&tochange=9f6b
> 6dd5134cf3cb0f372f815fa40a5ab6a2425a

https://hg.mozilla.org/integration/mozilla-inbound/rev/14932987629f
https://hg.mozilla.org/integration/mozilla-inbound/rev/9cf3c9833dd5

Looking through those changelogs, these two commits look the most likely to be related. My current theory is that this bug is probably being caused by code which stops trying to restore the tab's state if it is being closed, but I haven't tested this yet.

Comment 6

[aroskuski]

Attachment: initial-attempt.patch

So I'm having trouble generating a build to test this on (I suspect I'm doing something wrong, since, even without my changes, the build seems to just hang during startup), but this is basically the approach that seems to be necessary, since there was no code which canceled the operation before.

Comment 7

[aroskuski]

The behavior seems to have been fixed somewhere around Firefox 45.