Closed Bug 1218189 Opened 10 years ago Closed 10 years ago

Remove #abouthome-search-panel from browser code

Categories

(Firefox :: General, defect)

Product:
Firefox
Component:
General
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 45
Tracking Flags:
Tracking Status
firefox45 --- fixed

People

(Reporter: ntim, Assigned: hanue, Mentored)

Details

(Whiteboard: [good first bug][lang=xul][lang=css])

Attachments

(1 file, 1 obsolete file)

rev2 - XUL and CSS removal fixes
2.06 KB, patch
dao
: review+
ntim
: review+
Details | Diff | Splinter Review
https://dxr.mozilla.org/mozilla-central/search?q=abouthome-search+path%3Abrowser%2Fbase&redirect=false&case=true Some XUL and CSS references are remaining, they should be removed.
Mentor: ntim.bugs
Whiteboard: [good first bug][lang=xul][lang=css]
In the browser.xul file, remove the entire <panel> node? Or just remove the references to the id?
Attached patch rev1 - XUL and CSS removal fixes (obsolete) — — Splinter Review
Hello Tim! Please find attached my patch for this bug. Best regards, Eduard
Attachment #8684414 - Flags: review?(ntim.bugs)
(In reply to Andrew from comment #1) > In the browser.xul file, remove the entire <panel> node? Or just remove the > references to the id? Sorry for the late reply (please needinfo? me next time), the entire <panel> node needs to be removed.
Comment on attachment 8684414 [details] [diff] [review] rev1 - XUL and CSS removal fixes Review of attachment 8684414 [details] [diff] [review]: ----------------------------------------------------------------- Thanks for the patch ! ::: browser/base/content/browser.xul @@ +260,5 @@ > mousethrough="always"> > <box id="UITourHighlight"></box> > </panel> > > + <panel orient="vertical" type="arrow" hidden="true" The entire panel needs to be removed, not just the ids.
Attachment #8684414 - Flags: review?(ntim.bugs) → feedback+
Assignee: nobody → hanue
Status: NEW → UNCONFIRMED
Ever confirmed: false
Whoops.
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Roger that! Please find attached my updated patch.
Attachment #8684424 - Flags: review?(ntim.bugs)
Comment on attachment 8684424 [details] [diff] [review] rev2 - XUL and CSS removal fixes Review of attachment 8684424 [details] [diff] [review]: ----------------------------------------------------------------- Thanks ! Looks good to me, asked a peer to review it now.
Attachment #8684424 - Flags: review?(ntim.bugs)
Attachment #8684424 - Flags: review?(dao)
Attachment #8684424 - Flags: review+
Attachment #8684414 - Attachment is obsolete: true
Comment on attachment 8684424 [details] [diff] [review] rev2 - XUL and CSS removal fixes Looks good!
Attachment #8684424 - Flags: review?(dao) → review+
https://hg.mozilla.org/mozilla-central/rev/1918060c3a6a
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
status-firefox45: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 45
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: