1218228 - Reader View conversion loses h1 header elements

Status: RESOLVED DUPLICATE of bug 1198731

(Toolkit :: Reader Mode, defect)

Description

[Franklin?]

User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:41.0) Gecko/20100101 Firefox/41.0
Build ID: 20151014143721

Steps to reproduce:

View this page in Reader View:
https://ponyfoo.com/articles/es6-promises-in-depth
(archived: https://web.archive.org/web/20150928184517/http://ponyfoo.com/articles/es6-promises-in-depth)

The page uses <h1> tags for its main section headers.


Actual results:

Any text in <h1> tags are not carried over to the Reader View. The tags themselves are gone.


Expected results:

They should not disappear.

----

Good web design aside, H1 tags are now valid for use as section headers.
http://webdesign.tutsplus.com/articles/the-truth-about-multiple-h1-tags-in-the-html5-era--webdesign-16824

Comment 1

[:Gijs (he/him)]

(In reply to Franklin? from comment #0)
> Good web design aside, H1 tags are now valid for use as section headers.
> http://webdesign.tutsplus.com/articles/the-truth-about-multiple-h1-tags-in-
> the-html5-era--webdesign-16824

The article is just wrong. The spec has this warning:

There are currently no known native implementations of the outline algorithm in graphical browsers or assistive technology user agents, although the algorithm is implemented in other software such as conformance checkers and browser extensions. Therefore the outline algorithm cannot be relied upon to convey document structure to users. Authors should use heading rank (h1-h6) to convey document structure. 

Using multiple h1s on one page is not a good idea.

Comment 2

[Franklin?]

How does the warning show that the article is wrong? It warns that implementations haven't caught up. This is a bug report about an implementation. If anything, the existence of the warning suggests that the issue is valid.

Comment 3

[:Gijs (he/him)]

(In reply to Franklin? from comment #2)
> How does the warning show that the article is wrong? It warns that
> implementations haven't caught up. This is a bug report about an
> implementation. If anything, the existence of the warning suggests that the
> issue is valid.

"Authors should use heading rank (h1-h6) to convey document structure."

seems pretty clear.

In any case, I didn't mark the issue invalid, it was simply reported before. If and when there's time to do so, it'll be addressed in bug 1198731.

Comment 4

[Franklin?]

> In any case, I didn't mark the issue invalid, it was simply reported before. If and when there's time to do so, it'll be addressed in bug 1198731.

Fair.

> "Authors should use heading rank (h1-h6) to convey document structure."

(I said, "Good web design aside". I cited the article to show that it's a _valid_ (legal) use, not that it is a _recommended_ (moral) use.)