1218254 - bug 1216318 cause build break by C4819 w/ --enable-warnings-as-errors

Status: RESOLVED FIXED

(NSS :: Libraries, defect)

Description

[Makoto Kato [:m_kato]]

+++ This bug was initially created as a clone of Bug #1216318 +++

intel-gcm.h has non-ASCII character, so when I use --enable-warning-as-error, I cannot build m-c tree.

 1:00.60 c:\development\hg.mozilla.org\mozilla-inbound\security\nss\lib\freebl\i
ntel-gcm.h: error C2220: warning treated as error - no 'object' file generated
 1:00.60 c:\development\hg.mozilla.org\mozilla-inbound\security\nss\lib\freebl\i
ntel-gcm.h: warning C4819: The file contains a character that cannot be represen
ted in the current code page (932). Save the file in Unicode format to prevent d
ata loss

Comment 1

[Makoto Kato [:m_kato]]

Martin, could you handle this?

I think remove non-ASCII character from intel-gcm.h or add -wd4819 to CL.exe parameter list

Comment 2

[Martin Thomson [:mt:]]

Attachment: bug1218254.patch

Does this work for you?  I found 5 non-ASCII characters, one of which was an en-dash.  wc -m and wc -c now report the file as being the same size.

Comment 3

[Makoto Kato [:m_kato]]

Comment on attachment 8678674 [details] [diff] [review]
bug1218254.patch

Review of attachment 8678674 [details] [diff] [review]:
-----------------------------------------------------------------

Works fine.  Thanks.

Comment 4

[Martin Thomson [:mt:]]

https://hg.mozilla.org/projects/nss/rev/a2d5c6876ade

This probably won't land in m-c until we release NSS properly.  That might be later this week.

Comment 5

[Mike Hommey [:glandium]]

Comment on attachment 8678674 [details] [diff] [review]
bug1218254.patch

Review of attachment 8678674 [details] [diff] [review]:
-----------------------------------------------------------------

::: lib/freebl/intel-gcm.h
@@ +6,5 @@
>  /******************************************************************************/
>  /* Copyright(c) 2013, Intel Corp.                                             */
>  /******************************************************************************/
>  /* Reference:                                                                 */
> +/* [1] Shay Gueron, Michael E. Kounavis: Intel(C) Carry-Less Multiplication   */

(C) is not the same as ®. The former is "copyright", the latter is "registered trademark".

Comment 6

[Martin Thomson [:mt:]]

Attachment: bug1216318-2.patch

Oops, a consequence of having a very bad font at small size.  I should have been more careful.

Comment 7

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

:mt

This bug blocks to develop Firefox/Gecko on m-c even with --disable-warning-as-errors. Cannot merge NSS ASAP? The deadline of 44 is this weekend. So, the merge date is too late for us.

Comment 8

[Martin Thomson [:mt:]]

https://hg.mozilla.org/projects/nss/rev/87138be0ddf2

I will try to ensure that nss is updated before the uplift.

Comment 9

[Hector Zhao [:hectorz]]

FYI, the merge of m-c -> m-a will be tomorrow: https://groups.google.com/forum/#!msg/mozilla.dev.platform/e71M1z0YE_g/g7P1p6WACAAJ

Comment 10

[Martin Thomson [:mt:]]

It seems quite likely that the NSS release will not make this deadline.  However, we will request uplift of 3.21 to aurora.

Comment 11

[Kai Engert [:KaiE:]]

The Firefox 44 branch has received NSS 3.21, so apparently everything has been done as requested? clearing needinfo.