Closed Bug 1218295 Opened 4 years ago Closed 4 years ago

[Bluetooth] Convert the relative path of PullvCardEntry to absolute path if PBAP request isn’t using X-BT-UID.

Categories

(Firefox OS Graveyard :: Bluetooth, defect)

ARM
Gonk (Firefox OS)
defect
Not set

Tracking

(blocking-b2g:2.2r+, firefox44 fixed, b2g-v2.2r fixed)

RESOLVED FIXED
FxOS-S10 (30Oct)
blocking-b2g 2.2r+
Tracking Status
firefox44 --- fixed
b2g-v2.2r --- fixed

People

(Reporter: jaliu, Assigned: jaliu)

References

Details

Attachments

(2 files, 1 obsolete file)

Since FxOS doesn’t expose 'currentPath' of PBAP virtual folders structure to Gaia, BluetoothVCardPullingEvent should use absolute path to describe the vCard entry. But there is one exception, if PullvCardEntry uses contact unique identifier (X-BT-UID), it doesn’t need path of virtual folder.

Please refer to “5.4.2 Name, PBAP spec. 1.2” for more details.
Hi Ben,
Please help to review the patch.
Thank you.
Attachment #8678709 - Flags: review?(btian)
Comment on attachment 8678709 [details] [diff] [review]
(for m-c) Convert the relative path of PullvCardEntry to absolute path if PBAP request isn't using X-BT-UID. (v1)

Review of attachment 8678709 [details] [diff] [review]:
-----------------------------------------------------------------

r=me with comment addressed.

::: dom/bluetooth/bluedroid/BluetoothPbapManager.cpp
@@ +478,5 @@
>      tagCount = MOZ_ARRAY_LENGTH(sVCardEntryTags);
>      tags = sVCardEntryTags;
> +
> +    // Convert relative path to absolute path if it's not using X-BT-UID.
> +    if (name.Find(NS_LITERAL_STRING("X-BT-UID")) == -1) {

Replace -1 with |kNotFound|.
Attachment #8678709 - Flags: review?(btian) → review+
Assignee: nobody → 6jamin
Status: NEW → ASSIGNED
- revise previous patch based on #comment 2.

Thank Ben for reviewing the patch.
Attachment #8678709 - Attachment is obsolete: true
blocking-b2g: --- → 2.2r?
Set 2.2r blocker for required bluetooth feature PBAP.
Blocks: 1199528
blocking-b2g: 2.2r? → 2.2r+
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/5feb89aefb1c
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → FxOS-S10 (30Oct)
You need to log in before you can comment on or make changes to this bug.