1218295 - [Bluetooth] Convert the relative path of PullvCardEntry to absolute path if PBAP request isn’t using X-BT-UID.

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Bluetooth, defect)

Description

[Jamin Liu [:jaliu][:Jamin]]

Since FxOS doesn’t expose 'currentPath' of PBAP virtual folders structure to Gaia, BluetoothVCardPullingEvent should use absolute path to describe the vCard entry. But there is one exception, if PullvCardEntry uses contact unique identifier (X-BT-UID), it doesn’t need path of virtual folder.

Please refer to “5.4.2 Name, PBAP spec. 1.2” for more details.

Comment 1

[Jamin Liu [:jaliu][:Jamin]]

Attachment: (for m-c) Convert the relative path of PullvCardEntry to absolute path if PBAP request isn't using X-BT-UID. (v1)

Hi Ben,
Please help to review the patch.
Thank you.

Comment 2

[Ben Tian (inactive)]

Comment on attachment 8678709 [details] [diff] [review]
(for m-c) Convert the relative path of PullvCardEntry to absolute path if PBAP request isn't using X-BT-UID. (v1)

Review of attachment 8678709 [details] [diff] [review]:
-----------------------------------------------------------------

r=me with comment addressed.

::: dom/bluetooth/bluedroid/BluetoothPbapManager.cpp
@@ +478,5 @@
>      tagCount = MOZ_ARRAY_LENGTH(sVCardEntryTags);
>      tags = sVCardEntryTags;
> +
> +    // Convert relative path to absolute path if it's not using X-BT-UID.
> +    if (name.Find(NS_LITERAL_STRING("X-BT-UID")) == -1) {

Replace -1 with |kNotFound|.

Comment 3

[Jamin Liu [:jaliu][:Jamin]]

Attachment: (for m-c) Convert the relative path of PullvCardEntry to absolute path if PBAP request isn't using X-BT-UID. (v2), r=btian

- revise previous patch based on #comment 2.

Thank Ben for reviewing the patch.

Comment 4

[Jamin Liu [:jaliu][:Jamin]]

Attachment: (for 2.2r) Convert the relative path of PullvCardEntry to absolute path if PBAP request isn't using X-BT-UID. (v2), r=btian

Comment 5

[Ben Tian (inactive)]

Set 2.2r blocker for required bluetooth feature PBAP.

Comment 6

[Jamin Liu [:jaliu][:Jamin]]

#Attachment 8679267 [details] [diff] looks fine on treeherder.
https://treeherder.mozilla.org/#/jobs?repo=try&revision=d2cce815e2d6

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-b2g37_v2_2r/rev/3db349aedbab

Comment 8

[Pulsebot]

https://hg.mozilla.org/integration/b2g-inbound/rev/5feb89aefb1c

Comment 9

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/5feb89aefb1c