Closed Bug 1218311 Opened 6 years ago Closed 6 years ago

Port the fix of bug 1193614 to VideoSink

Categories

(Core :: Audio/Video: Playback, defect, P2)

defect

Tracking

()

RESOLVED FIXED
mozilla45
Tracking Status
firefox45 --- fixed

People

(Reporter: jwwang, Assigned: jwwang)

References

Details

Attachments

(1 file)

https://bugzilla.mozilla.org/page.cgi?id=splinter.html&bug=1193614&attachment=8676740

We need this change for VideoSink to ensure smooth playback on high quality video.
Assignee: nobody → jwwang
Depends on: 1193614
Bug 1218311 - Port the fix of bug 1193614 to VideoSink. r=cpearce.
Attachment #8678761 - Flags: review?(cpearce)
Comment on attachment 8678761 [details]
MozReview Request: Bug 1218311 - Port the fix of bug 1193614 to VideoSink.

Dan: This patch touches your recent change to improve state machine perf; does this patch regress the gains you made?
Attachment #8678761 - Flags: feedback?(dglastonbury)
Comment on attachment 8678761 [details]
MozReview Request: Bug 1218311 - Port the fix of bug 1193614 to VideoSink.

I've looked over the changes made by this patch and I believe it implements the same functionality as I made in 1193614.
Attachment #8678761 - Flags: feedback?(dglastonbury) → feedback+
Attachment #8678761 - Flags: review?(cpearce) → review+
Comment on attachment 8678761 [details]
MozReview Request: Bug 1218311 - Port the fix of bug 1193614 to VideoSink.

https://reviewboard.mozilla.org/r/23245/#review21319

Sorry for delay r+ing this.
Thanks for the review!
Priority: -- → P2
https://treeherder.mozilla.org/logviewer.html#?job_id=16725447&repo=mozilla-inbound
It was backed out for the failure in test_reset_src.html on Andorid 2.3. I can't tell anything from the crash stack.
Attachment #8678761 - Attachment description: MozReview Request: Bug 1218311 - Port the fix of bug 1193614 to VideoSink. r=cpearce. → MozReview Request: Bug 1218311 - Port the fix of bug 1193614 to VideoSink.
Attachment #8678761 - Flags: feedback+
Comment on attachment 8678761 [details]
MozReview Request: Bug 1218311 - Port the fix of bug 1193614 to VideoSink.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/23245/diff/1-2/
Comment on attachment 8678761 [details]
MozReview Request: Bug 1218311 - Port the fix of bug 1193614 to VideoSink.

This patch has a small improvement over the previous one by not triggering render loops upon the frames that have been rendered. This seems to fix the mysterious crash on Android 9.

try is green now.
https://treeherder.mozilla.org/#/jobs?repo=try&revision=4a9be17e1ee1
Attachment #8678761 - Flags: review+ → review?(cpearce)
Comment on attachment 8678761 [details]
MozReview Request: Bug 1218311 - Port the fix of bug 1193614 to VideoSink.

https://reviewboard.mozilla.org/r/23245/#review23539
Attachment #8678761 - Flags: review?(cpearce) → review+
Thanks!
https://hg.mozilla.org/mozilla-central/rev/0288a0a7003f
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla45
You need to log in before you can comment on or make changes to this bug.