Port the fix of bug 1193614 to VideoSink

RESOLVED FIXED in Firefox 45

Status

()

Core
Audio/Video: Playback
P2
normal
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: jwwang, Assigned: jwwang)

Tracking

unspecified
mozilla45
Points:
---

Firefox Tracking Flags

(firefox45 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Assignee)

Description

2 years ago
https://bugzilla.mozilla.org/page.cgi?id=splinter.html&bug=1193614&attachment=8676740

We need this change for VideoSink to ensure smooth playback on high quality video.
(Assignee)

Updated

2 years ago
Assignee: nobody → jwwang
Depends on: 1193614
(Assignee)

Comment 1

2 years ago
try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=e1cebb43df4f
(Assignee)

Comment 2

2 years ago
Created attachment 8678761 [details]
MozReview Request: Bug 1218311 - Port the fix of bug 1193614 to VideoSink.

Bug 1218311 - Port the fix of bug 1193614 to VideoSink. r=cpearce.
Attachment #8678761 - Flags: review?(cpearce)
Comment on attachment 8678761 [details]
MozReview Request: Bug 1218311 - Port the fix of bug 1193614 to VideoSink.

Dan: This patch touches your recent change to improve state machine perf; does this patch regress the gains you made?
Attachment #8678761 - Flags: feedback?(dglastonbury)
Comment on attachment 8678761 [details]
MozReview Request: Bug 1218311 - Port the fix of bug 1193614 to VideoSink.

I've looked over the changes made by this patch and I believe it implements the same functionality as I made in 1193614.
Attachment #8678761 - Flags: feedback?(dglastonbury) → feedback+
Attachment #8678761 - Flags: review?(cpearce) → review+
Comment on attachment 8678761 [details]
MozReview Request: Bug 1218311 - Port the fix of bug 1193614 to VideoSink.

https://reviewboard.mozilla.org/r/23245/#review21319

Sorry for delay r+ing this.
(Assignee)

Comment 6

2 years ago
Thanks for the review!

Comment 7

2 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/9ce253c10b9a

Comment 8

2 years ago
Backout:
https://hg.mozilla.org/mozilla-central/rev/d84d28b5c9be
Priority: -- → P2
(Assignee)

Comment 9

2 years ago
https://treeherder.mozilla.org/logviewer.html#?job_id=16725447&repo=mozilla-inbound
It was backed out for the failure in test_reset_src.html on Andorid 2.3. I can't tell anything from the crash stack.
(Assignee)

Comment 10

2 years ago
try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=4a9be17e1ee1
(Assignee)

Updated

2 years ago
Attachment #8678761 - Attachment description: MozReview Request: Bug 1218311 - Port the fix of bug 1193614 to VideoSink. r=cpearce. → MozReview Request: Bug 1218311 - Port the fix of bug 1193614 to VideoSink.
Attachment #8678761 - Flags: feedback+
(Assignee)

Comment 11

2 years ago
Comment on attachment 8678761 [details]
MozReview Request: Bug 1218311 - Port the fix of bug 1193614 to VideoSink.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/23245/diff/1-2/
(Assignee)

Comment 12

2 years ago
Comment on attachment 8678761 [details]
MozReview Request: Bug 1218311 - Port the fix of bug 1193614 to VideoSink.

This patch has a small improvement over the previous one by not triggering render loops upon the frames that have been rendered. This seems to fix the mysterious crash on Android 9.

try is green now.
https://treeherder.mozilla.org/#/jobs?repo=try&revision=4a9be17e1ee1
Attachment #8678761 - Flags: review+ → review?(cpearce)
Comment on attachment 8678761 [details]
MozReview Request: Bug 1218311 - Port the fix of bug 1193614 to VideoSink.

https://reviewboard.mozilla.org/r/23245/#review23539
Attachment #8678761 - Flags: review?(cpearce) → review+
(Assignee)

Comment 14

2 years ago
Thanks!

Comment 15

2 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/0288a0a7003f

Comment 16

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/0288a0a7003f
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox45: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla45
You need to log in before you can comment on or make changes to this bug.