1218311 - Port the fix of bug 1193614 to VideoSink

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect, P2)

Description

[JW Wang [:jwwang] [:jw_wang]]

https://bugzilla.mozilla.org/page.cgi?id=splinter.html&bug=1193614&attachment=8676740

We need this change for VideoSink to ensure smooth playback on high quality video.

Comment 1

[JW Wang [:jwwang] [:jw_wang]]

try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=e1cebb43df4f

Comment 2

[JW Wang [:jwwang] [:jw_wang]]

Attachment: MozReview Request: Bug 1218311 - Port the fix of bug 1193614 to VideoSink.

Bug 1218311 - Port the fix of bug 1193614 to VideoSink. r=cpearce.

Comment 3

[Chris Pearce [:cpearce (Not reading bugmail)]]

Comment on attachment 8678761 [details]
MozReview Request: Bug 1218311 - Port the fix of bug 1193614 to VideoSink.

Dan: This patch touches your recent change to improve state machine perf; does this patch regress the gains you made?

Comment 4

[u480271]

Comment on attachment 8678761 [details]
MozReview Request: Bug 1218311 - Port the fix of bug 1193614 to VideoSink.

I've looked over the changes made by this patch and I believe it implements the same functionality as I made in 1193614.

Comment 5

[Chris Pearce [:cpearce (Not reading bugmail)]]

Comment on attachment 8678761 [details]
MozReview Request: Bug 1218311 - Port the fix of bug 1193614 to VideoSink.

https://reviewboard.mozilla.org/r/23245/#review21319

Sorry for delay r+ing this.

Comment 6

[JW Wang [:jwwang] [:jw_wang]]

Thanks for the review!

Comment 7

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/9ce253c10b9a

Comment 8

[Pulsebot]

Backout:
https://hg.mozilla.org/mozilla-central/rev/d84d28b5c9be

Comment 9

[JW Wang [:jwwang] [:jw_wang]]

https://treeherder.mozilla.org/logviewer.html#?job_id=16725447&repo=mozilla-inbound
It was backed out for the failure in test_reset_src.html on Andorid 2.3. I can't tell anything from the crash stack.

Comment 10

[JW Wang [:jwwang] [:jw_wang]]

try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=4a9be17e1ee1

Comment 11

[JW Wang [:jwwang] [:jw_wang]]

Comment on attachment 8678761 [details]
MozReview Request: Bug 1218311 - Port the fix of bug 1193614 to VideoSink.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/23245/diff/1-2/

Comment 12

[JW Wang [:jwwang] [:jw_wang]]

Comment on attachment 8678761 [details]
MozReview Request: Bug 1218311 - Port the fix of bug 1193614 to VideoSink.

This patch has a small improvement over the previous one by not triggering render loops upon the frames that have been rendered. This seems to fix the mysterious crash on Android 9.

try is green now.
https://treeherder.mozilla.org/#/jobs?repo=try&revision=4a9be17e1ee1

Comment 13

[Chris Pearce [:cpearce (Not reading bugmail)]]

Comment on attachment 8678761 [details]
MozReview Request: Bug 1218311 - Port the fix of bug 1193614 to VideoSink.

https://reviewboard.mozilla.org/r/23245/#review23539

Comment 14

[JW Wang [:jwwang] [:jw_wang]]

Thanks!

Comment 15

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/0288a0a7003f

Comment 16

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/0288a0a7003f