Improve the referrer checks in worker mochitests

RESOLVED FIXED in Firefox 45

Status

()

defect
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: bzbarsky, Assigned: baku)

Tracking

Trunk
mozilla45
Points:
---

Firefox Tracking Flags

(firefox44 affected, firefox45 fixed)

Details

Attachments

(1 attachment)

Right now it looks to me like neither toplevel worker loads nor importScripts set any referrers.  They should, as far as I can tell per spec.
Assignee

Comment 1

4 years ago
https://mxr.mozilla.org/mozilla-central/source/dom/workers/ScriptLoader.cpp#194
We do set a referrer in ScriptLoader. Is it not enough?
Hmm.  I filed the bug based on the claim in bug 1218110 comment 10 that importScripts does not send a referrer header.  Could we check whether it actually does?  It's possible the claim was just wrong.
Assignee

Comment 4

4 years ago
Posted patch ref.patchSplinter Review
Definitely invalid. But I wrote a test. Nice to land it.
Attachment #8689191 - Flags: review?(bkelly)
Assignee

Updated

4 years ago
Assignee: nobody → amarchesini
Assignee

Updated

4 years ago
Summary: Various worker channels should have a referer header → Improve the referrer checks in worker mochitests
Attachment #8689191 - Flags: review?(bkelly) → review+
Thanks!  Sorry for the lack of context on the original bug.

Comment 7

4 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/bc5aaa4b23f2
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla45
You need to log in before you can comment on or make changes to this bug.