Closed
Bug 1218474
Opened 9 years ago
Closed 9 years ago
Improve the referrer checks in worker mochitests
Categories
(Core :: DOM: Workers, defect)
Core
DOM: Workers
Tracking
()
RESOLVED
FIXED
mozilla45
People
(Reporter: bzbarsky, Assigned: baku)
Details
Attachments
(1 file)
|
3.55 KB,
patch
|
bkelly
:
review+
|
Details | Diff | Splinter Review |
Right now it looks to me like neither toplevel worker loads nor importScripts set any referrers. They should, as far as I can tell per spec.
|
Assignee | |
Comment 1•9 years ago
|
||
https://mxr.mozilla.org/mozilla-central/source/dom/workers/ScriptLoader.cpp#194 We do set a referrer in ScriptLoader. Is it not enough?
|
||
Comment 2•9 years ago
|
||
It seems we even have a test for the top level script case: https://dxr.mozilla.org/mozilla-central/source/dom/workers/test/test_referrer.html
|
Reporter | |
Comment 3•9 years ago
|
||
Hmm. I filed the bug based on the claim in bug 1218110 comment 10 that importScripts does not send a referrer header. Could we check whether it actually does? It's possible the claim was just wrong.
|
|
Assignee | |
Comment 4•9 years ago
|
||
Definitely invalid. But I wrote a test. Nice to land it.
Attachment #8689191 -
Flags: review?(bkelly)
|
|
Assignee | |
Updated•9 years ago
|
Assignee: nobody → amarchesini
|
|
Assignee | |
Updated•9 years ago
|
Summary: Various worker channels should have a referer header → Improve the referrer checks in worker mochitests
|
|
||
Updated•9 years ago
|
Attachment #8689191 -
Flags: review?(bkelly) → review+
|
|
Reporter | |
Comment 5•9 years ago
|
||
Thanks! Sorry for the lack of context on the original bug.
|
||
Comment 7•9 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/bc5aaa4b23f2
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox45:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla45
You need to log in
before you can comment on or make changes to this bug.
Description
•