Closed Bug 1218474 Opened 8 years ago Closed 7 years ago

Improve the referrer checks in worker mochitests

Categories

(Core :: DOM: Workers, defect)

Product:
Core
Component:
DOM: Workers
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla45
Tracking Flags:
Tracking Status
firefox44 --- affected
firefox45 --- fixed

People

(Reporter: bzbarsky, Assigned: baku)

Details

Attachments

(1 file)

ref.patch
3.55 KB, patch
bkelly
: review+
Details | Diff | Splinter Review 
Right now it looks to me like neither toplevel worker loads nor importScripts set any referrers.  They should, as far as I can tell per spec.
https://mxr.mozilla.org/mozilla-central/source/dom/workers/ScriptLoader.cpp#194
We do set a referrer in ScriptLoader. Is it not enough?
Hmm.  I filed the bug based on the claim in bug 1218110 comment 10 that importScripts does not send a referrer header.  Could we check whether it actually does?  It's possible the claim was just wrong.
Attached patch ref.patch — — Splinter Review 
Definitely invalid. But I wrote a test. Nice to land it.
Attachment #8689191 - Flags: review?(bkelly)
Assignee: nobody → amarchesini
Summary: Various worker channels should have a referer header → Improve the referrer checks in worker mochitests
Attachment #8689191 - Flags: review?(bkelly) → review+
Thanks!  Sorry for the lack of context on the original bug.
https://hg.mozilla.org/mozilla-central/rev/bc5aaa4b23f2
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox45: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla45
You need to log in before you can comment on or make changes to this bug.