Closed Bug 1218520 Opened 6 years ago Closed 6 years ago

Integration test for bookmarks / favourites

Categories

(Firefox OS Graveyard :: Gaia::FMRadio, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
2.6 S2 - 12/4

People

(Reporter: hub, Assigned: hub)

References

Details

Attachments

(2 files)

This is following bug 1217234, we should test the favourite / bookmark feature in the FM Radio.
Blocks: 1218519
Assignee: nobody → hub
Status: NEW → ASSIGNED
Bug 796422 prevents from testing bookmarks completely since once there is one bookmark, the bug is trigger and one can't add a second one since we can't tap on the not on screen element.
Depends on: 796422
Comment on attachment 8689158 [details] [review]
[gaia] hfiguiere:bug1218520-radio-favs-test > mozilla-b2g:master

Part 1 of the tests.
Attachment #8689158 - Flags: review?(jdarcangelo)
Attachment #8689158 - Flags: review?(jdarcangelo) → review+
Target Milestone: --- → 2.6 S1 - 11/20
Comment on attachment 8691220 [details] [review]
[gaia] hfiguiere:bug1218520-radio-favs-test-part2 > mozilla-b2g:master

I took the approach to not wait for the fix of scrollIntoView()
Attachment #8691220 - Flags: review?(jdarcangelo)
Comment on attachment 8691220 [details] [review]
[gaia] hfiguiere:bug1218520-radio-favs-test-part2 > mozilla-b2g:master

LGTM. Too bad we don't have a working scrollIntoView() yet :-/
Attachment #8691220 - Flags: review?(jdarcangelo) → review+
Merged
https://github.com/mozilla-b2g/gaia/commit/4d59fbe7aeac4a3fd16135d2f52be47f4b189b43
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: 2.6 S1 - 11/20 → 2.6 S2 - 12/4
No longer depends on: 796422
You need to log in before you can comment on or make changes to this bug.