Closed Bug 1218582 Opened 6 years ago Closed 6 years ago

Add b2g/b2gdroid app UIDs to AMO service

Categories

(Toolkit :: Blocklist Policy Requests, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: ddurst, Assigned: andy+bugzilla)

References

Details

In order for FxOS to use AMO's blocklisting, we need to add the app UIDs to the list (because they don't yet exist).

Blocking 1195470 just so we don't lose it. We can remove that with a META if someone prefers.
Could you tell us the GUIDs for b2g and b2gdroid please?
Flags: needinfo?(fabrice)
Assignee: nobody → amckay
b2g: {3c2e2abc-06d4-11e1-ac3b-374f68613e61}
b2gdroid: {f7b06d8d-139c-459a-85fa-46bc6c52e2b7}
Flags: needinfo?(fabrice)
By playing around with the blocklist in my local dev environment I was able to get something that looked like:

/blocklist/3/%7B3c2e2abc-06d4-11e1-ac3b-374f68613e61%7D/2.5/

<blocklist lastupdate="1445968337000">
 <emItems> 
  <emItem blockID="i1" id="some-app-id@firefox-os">
   <versionRange>
    <targetApplication id="{3c2e2abc-06d4-11e1-ac3b-374f68613e61}"></targetApplication>
   </versionRange>
   <prefs></prefs>
  </emItem>
 </emItems>
</blocklist>

I'll let jorgev tell me if it looks right, I kinda confess I was clicking around in the AMO admin a bit. Looks like there's a lot of option in there :)

This didn't require any code changes, since the block list is quite divorced from AMO. The only page that won't show up is a Firefox OS version of this page: https://addons.mozilla.org/en-US/firefox/blocked/,

For that we have to add in Firefox OS to the bigger AMO site and having Firefox OS appear all over AMO is probably not something we want to do today.

Does that look ok from your point of view jorgev?
Flags: needinfo?(jorge)
There are some samples here: https://wiki.mozilla.org/Blocklisting/Admin

A couple of things look different, though I'm not sure if they are necessarily wrong:

* The min and max version of the extension, and the severity of the block are always set.
* The same goes for the min and max version of the target application.
Flags: needinfo?(jorge)
Example for testing here:

https://blocklist.allizom.org/blocklist/3/%7B3c2e2abc-06d4-11e1-ac3b-374f68613e61%7D/2.5/
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Product: addons.mozilla.org → Toolkit
You need to log in before you can comment on or make changes to this bug.