Closed Bug 1218592 Opened 4 years ago Closed 4 years ago

Add more robust error handling and reporting to the memory tool's actions

Categories

(DevTools :: Memory, defect)

defect
Not set

Tracking

(firefox44 fixed)

RESOLVED FIXED
Firefox 44
Tracking Status
firefox44 --- fixed

People

(Reporter: fitzgen, Assigned: fitzgen)

References

Details

Attachments

(1 file)

We need to make sure to catch errors when interacting with the
HeapAnalysesWorker or the MemoryActor and when we do (inevitably) get errors,
the UI needs to report it somewhat gracefully.
Assignee: nobody → nfitzgerald
Status: NEW → ASSIGNED
Comment on attachment 8679136 [details] [diff] [review]
Add more robust error handling and reporting to the memory tool's actions

Review of attachment 8679136 [details] [diff] [review]:
-----------------------------------------------------------------

::: devtools/client/memory/components/heap.js
@@ +78,5 @@
>          break;
> +      case states.ERROR:
> +        pane = dom.div({ className: "heap-view-panel" },
> +                       dom.h2({}, "There was an error processing this snapshot"),
> +                       dom.pre({}, safeErrorString(snapshot.error)));

Why can't `getSnapshotStatusText` handle this formatting? the data-state prop would allow different kinds of styling where needed, and all state styling handled in bug 1218674

::: devtools/client/memory/utils.js
@@ +95,5 @@
>      `Snapshot must have expected state, found ${(snapshot || {}).state}.`);
>  
>    switch (snapshot.state) {
> +    case states.ERROR:
> +      return ERROR_SNAPSHOT_TEXT;

bleh, this is only used in the list view status -- whereas all other states use the same in both list view and heap view, which is probably just because we're half-**** the status messaging for now pre-l10n. I guess the solution here is a long and short version.
Attachment #8679136 - Flags: review?(jsantell) → review+
https://hg.mozilla.org/mozilla-central/rev/7894e641adfa
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 44
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.