1218592 - Add more robust error handling and reporting to the memory tool's actions

Status: RESOLVED FIXED

(DevTools :: Memory, defect)

Description

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

We need to make sure to catch errors when interacting with the
HeapAnalysesWorker or the MemoryActor and when we do (inevitably) get errors,
the UI needs to report it somewhat gracefully.

Comment 1

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

Attachment: Add more robust error handling and reporting to the memory tool's actions

Comment 2

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

Try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=8501320bbe8e

Comment 3

[Jordan Santell [:jsantell] [@jsantell]]

Comment on attachment 8679136 [details] [diff] [review]
Add more robust error handling and reporting to the memory tool's actions

Review of attachment 8679136 [details] [diff] [review]:
-----------------------------------------------------------------

::: devtools/client/memory/components/heap.js
@@ +78,5 @@
>          break;
> +      case states.ERROR:
> +        pane = dom.div({ className: "heap-view-panel" },
> +                       dom.h2({}, "There was an error processing this snapshot"),
> +                       dom.pre({}, safeErrorString(snapshot.error)));

Why can't `getSnapshotStatusText` handle this formatting? the data-state prop would allow different kinds of styling where needed, and all state styling handled in bug 1218674

::: devtools/client/memory/utils.js
@@ +95,5 @@
>      `Snapshot must have expected state, found ${(snapshot || {}).state}.`);
>  
>    switch (snapshot.state) {
> +    case states.ERROR:
> +      return ERROR_SNAPSHOT_TEXT;

bleh, this is only used in the list view status -- whereas all other states use the same in both list view and heap view, which is probably just because we're half-**** the status messaging for now pre-l10n. I guess the solution here is a long and short version.

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/7894e641adfa

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/7894e641adfa