Closed Bug 1218652 Opened 8 years ago Closed 8 years ago

IonMonkey: MIPS: Add mips-shared in check macro assembler sytle

Categories

(Core :: JavaScript Engine: JIT, defect)

Product:
Core
Component:
JavaScript Engine: JIT
Platform:
Other
Linux
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla44
Tracking Flags:
Tracking Status
firefox44 --- fixed

People

(Reporter: hev, Assigned: hev)

References

Details

Attachments

(2 files, 1 obsolete file)

Part 1: Move shared functions to mips-shared.
15.85 KB, patch
arai
: review+
Details | Diff | Splinter Review
Part 2: Add mips-shared in check macroassembler style.
3.21 KB, patch
arai
: review+
Details | Diff | Splinter Review 
1. Move functions that mark as pre_shared_arch to mips-shared.
2. Add mips-shared in check macro assembler sytle.
Depends on: 1140954
Blocks: 1140954
No longer depends on: 1140954
Blocks: 1194139
No longer blocks: 1140954

        Attachment #8679235 -
        Flags: review?(arai.unmht)

    
    

    
  


  

        Attachment #8679236 -
        Flags: review?(arai.unmht)

    
  

        Attachment #8679235 -
        Attachment is obsolete: true

        Attachment #8679235 -
        Flags: review?(arai.unmht)

    
  

        Attachment #8679236 -
        Attachment is obsolete: true

        Attachment #8679236 -
        Flags: review?(arai.unmht)

    
  

        Attachment #8679236 -
        Attachment is obsolete: false

        Attachment #8679236 -
        Flags: review?(arai.unmht)

    
    

    
  


  

        Attachment #8679253 -
        Flags: review?(arai.unmht)

    
  

        Attachment #8679253 -
        Attachment is obsolete: true

        Attachment #8679253 -
        Flags: review?(arai.unmht)

    
    

    
  
Comment on attachment 8679235 [details] [diff] [review]
Part 1: Move shared functions to mips-shared.

Import mips64 support for Push/PopRegsInMask in bug 1213746 might be better.

        Attachment #8679235 -
        Attachment is obsolete: false

        Attachment #8679235 -
        Flags: review?(arai.unmht)

    
    

    
  
Comment on attachment 8679235 [details] [diff] [review]
Part 1: Move shared functions to mips-shared.

Review of attachment 8679235 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good :)

        Attachment #8679235 -
        Flags: review?(arai.unmht) → review+

        Attachment #8679236 -
        Flags: review?(arai.unmht) → review+

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/421e7471928d
https://hg.mozilla.org/mozilla-central/rev/afa59d4524cc
Status: ASSIGNED → RESOLVED
Closed: 8 years ago

          status-firefox44:
          affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla44

          You need to log in
          before you can comment on or make changes to this bug.