1218667 - Backout asyncOpen2() of Navigator::SendBeacon() for FF43

Status: RESOLVED WONTFIX

(Core :: DOM: Security, defect)

Description

[Christoph Kerschbaumer [:ckerschb]]

As discussed within https://bugzilla.mozilla.org/show_bug.cgi?id=1182537#c31 we should back out the usage of AsyncOpen2() within Navgiator::sendBeacon().

Comment 1

[Christoph Kerschbaumer [:ckerschb]]

Attachment: backout_bug_1182537_aurora.patch

Jonas, the backout patch applies cleanly to all files, but Navigator.cpp. Can you help me move this forward please. I think we shouldn't need the CorsListenerProxy anymore after bug 1199049 has landed, right?

Comment 2

[Christoph Kerschbaumer [:ckerschb]]

Attachment: Navigator.cpp.rej

Also providing the *.rej just in case so we don't miss any important details here.

Comment 3

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

You still need to call nsIHttpChannelInternal.setCorsPreflightParameters. And you still need a redirect listener.

Comment 4

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Actually, an easier option might actually be to uplift the patch in bug 1211000 to aurora. That would be an easier way to fix the involved security issues.

Comment 5

[Christoph Kerschbaumer [:ckerschb]]

(In reply to Jonas Sicking (:sicking) from comment #4)
> Actually, an easier option might actually be to uplift the patch in bug
> 1211000 to aurora. That would be an easier way to fix the involved security
> issues.

Most likely we can mark this bug as a dup of Bug 1211000, but for tracking I mark it as a dependency for now.

Comment 6

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Given that bug 1211000 has been uplifted, this is no longer needed.