Closed
Bug 1218670
Opened 9 years ago
Closed 9 years ago
Add % to heap view
Categories
(DevTools :: Memory, defect)
DevTools
Memory
Tracking
(firefox45 fixed)
RESOLVED
FIXED
Firefox 45
Tracking | Status | |
---|---|---|
firefox45 | --- | fixed |
People
(Reporter: fitzgen, Assigned: fitzgen)
References
Details
Attachments
(1 file, 1 obsolete file)
13.73 KB,
patch
|
fitzgen
:
review+
|
Details | Diff | Splinter Review |
We could calculate this stuff on demand when rendering, or compute it up front in the heap worker.
Assignee | ||
Updated•9 years ago
|
Assignee: nobody → nfitzgerald
Status: NEW → ASSIGNED
Assignee | ||
Comment 1•9 years ago
|
||
Attachment #8680553 -
Flags: review?(jsantell)
Comment 2•9 years ago
|
||
Comment on attachment 8680553 [details] [diff] [review] Add % to heap view tree items Review of attachment 8680553 [details] [diff] [review]: ----------------------------------------------------------------- some l10n nits, and haven't pulled down the patch, but the header spans in the screenshot[0] here you sent need to have some left margin (not sure why that regressed) [0] https://usercontent.irccloud-cdn.com/file/sfIc6XQi/Screen%20Shot%202015-10-29%20at%202.40.38%20AM.png ::: devtools/client/memory/components/toolbar.js @@ +41,5 @@ > }), > > dom.label({}, > L10N.getStr("toolbar.breakdownBy"), > + " ", this should be handled via styling, or at the very least, l10n ::: devtools/client/memory/components/tree-item.js @@ +18,5 @@ > const TreeItem = module.exports = createClass({ > displayName: "tree-item", > > + formatPercent(percent) { > + return Math.round(percent) + "%"; l10n
Attachment #8680553 -
Flags: review?(jsantell) → review+
Comment 3•9 years ago
|
||
Comment on attachment 8680553 [details] [diff] [review] Add % to heap view tree items Review of attachment 8680553 [details] [diff] [review]: ----------------------------------------------------------------- some l10n nits, and haven't pulled down the patch, but the header spans in the screenshot[0] here you sent need to have some left margin (not sure why that regressed) [0] https://usercontent.irccloud-cdn.com/file/sfIc6XQi/Screen%20Shot%202015-10-29%20at%202.40.38%20AM.png ::: devtools/client/memory/components/toolbar.js @@ +41,5 @@ > }), > > dom.label({}, > L10N.getStr("toolbar.breakdownBy"), > + " ", this should be handled via styling, or at the very least, l10n ::: devtools/client/memory/components/tree-item.js @@ +18,5 @@ > const TreeItem = module.exports = createClass({ > displayName: "tree-item", > > + formatPercent(percent) { > + return Math.round(percent) + "%"; L10N.getFormatStr("percentage", percent); and the string being just "%S%", the second possibly needing escaped, check out performance.properties
Assignee | ||
Comment 4•9 years ago
|
||
Attachment #8680661 -
Flags: review+
Assignee | ||
Updated•9 years ago
|
Attachment #8680553 -
Attachment is obsolete: true
Comment 6•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/8b2eb24d1b35
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox45:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 45
Assignee | ||
Comment 7•9 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=mozilla-aurora&revision=cb029edb917f
Comment 8•9 years ago
|
||
bugherder uplift |
https://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/8b2eb24d1b35
status-b2g-v2.5:
--- → fixed
Comment 9•9 years ago
|
||
bugherder uplift |
https://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/99a46382ddf1
status-b2g-v2.5:
fixed → ---
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•