1218673 - Style toolbar in memory tool

Status: RESOLVED FIXED

(DevTools :: Memory, defect)

Description

[Jordan Santell [:jsantell] [@jsantell]]

Style select element for breakdown, padding between checkboxes, tooltips, make it pretty

Comment 1

[Jordan Santell [:jsantell] [@jsantell]]

Attachment: 1218673-toolbar-style.patch

Comment 2

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

Comment on attachment 8680925 [details] [diff] [review]
1218673-toolbar-style.patch

Review of attachment 8680925 [details] [diff] [review]:
-----------------------------------------------------------------

\o/

Comment 3

[Victor Porof [:vporof][:vp]]

Comment on attachment 8680925 [details] [diff] [review]
1218673-toolbar-style.patch

Review of attachment 8680925 [details] [diff] [review]:
-----------------------------------------------------------------

:)

::: devtools/client/themes/memory.css
@@ +82,5 @@
>    height: var(--toolbar-height);
>  }
>  
> +.devtools-toolbar .toolbar-group {
> +  position: absolute;

nonono, flexbox pls.

@@ +83,5 @@
>  }
>  
> +.devtools-toolbar .toolbar-group {
> +  position: absolute;
> +  left: 186px;

there's a variable now.

@@ +89,5 @@
> +  white-space: nowrap;
> +}
> +
> +.toolbar-group > label {
> +  margin-right: 5px;

localize

@@ +93,5 @@
> +  margin-right: 5px;
> +}
> +
> +.toolbar-group .breakdown-by span {
> +  margin-right: 5px;

localize

Comment 4

[Jordan Santell [:jsantell] [@jsantell]]

In the process of uplifting, any changes have to be filed in another bug

Comment 5

[Victor Porof [:vporof][:vp]]

(In reply to Jordan Santell [:jsantell] [@jsantell] from comment #4)
> In the process of uplifting, any changes have to be filed in another bug

But this isn't even apply on top of bug 1213100.

Comment 6

[Jordan Santell [:jsantell] [@jsantell]]

I have a deep patch queue all merged in memory.css and don't want to redo again for both branches

Comment 7

[Victor Porof [:vporof][:vp]]

-_-

Comment 8

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/2b3c135ca9ca

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/2b3c135ca9ca

Comment 10

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

https://treeherder.mozilla.org/#/jobs?repo=mozilla-aurora&revision=cb029edb917f

Comment 11

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/2b3c135ca9ca

Comment 12

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/7dc7660b754f