1218681 - plugin standalone process support on MIPS processor.

Status: RESOLVED FIXED

(Core :: IPC, defect)

Description

[huangwenjun06]

Attachment: 0001-add-plugin-container-standalone-process-code.-The-Co.patch

User Agent: Mozilla/5.0 (Windows NT 6.1) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/46.0.2490.80 Safari/537.36

Steps to reproduce:

1:Build firefox Browser on mips processor. such as Loongson3A
2:open website url: such as www.163.com.
3:when flash crashed, firefox crashed


Actual results:

 firefox browser crashed when flash crashed immediately


Expected results:

firefox should not crashed , even if flash crashed. because flash plugin run in plugin-container process

Comment 1

[hev [:hev]]

Comment on attachment 8679273 [details] [diff] [review]
0001-add-plugin-container-standalone-process-code.-The-Co.patch

Review of attachment 8679273 [details] [diff] [review]:
-----------------------------------------------------------------

::: ipc/chromium/src/base/process_util.h
@@ +37,5 @@
>  #include "base/command_line.h"
>  #include "base/process.h"
>  
> +
> +#define ARCH_CPU_MIPSEL 1

You shouldn't define here.

See: ipc/chromium/src/build/build_config.h

@@ +74,5 @@
>    PROCESS_ARCH_I386 = 0x1,
>    PROCESS_ARCH_X86_64 = 0x2,
>    PROCESS_ARCH_PPC = 0x4,
> +  PROCESS_ARCH_ARM = 0x8,
> +  PROCESS_ARCH_MIPS = 0x16

Why not 0x10?

Comment 2

[huangwenjun06]

Thanks.

#define ARCH_CPU_MIPSEL 1 may should define here below. 
ipc/chromium/src/build/build_config.h

#elif defined(__mips__)
#define ARCH_CPU_MIPS 1
#define ARCH_CPU_32_BITS 1


See: ipc/chromium/src/build/build_config.h

@@ +74,5 @@
>    PROCESS_ARCH_I386 = 0x1,
>    PROCESS_ARCH_X86_64 = 0x2,
>    PROCESS_ARCH_PPC = 0x4,
> +  PROCESS_ARCH_ARM = 0x8,
> +  PROCESS_ARCH_MIPS = 0x10

may be it should 0x10; because a power of 2. but it doesn't matter.

Comment 3

[huangwenjun06]

Attachment: 0001-add-plugin-container-standalone-process-code.-The-Co.patch

Modify the code to make it more logical

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/80188cfd9a5c

Comment 5

[Gingerbread Man]

Comment on attachment 8680476 [details] [diff] [review]
0001-add-plugin-container-standalone-process-code.-The-Co.patch

I'm only involved with triage. Clearing patch review request.

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/80188cfd9a5c

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/80188cfd9a5c

Comment 8

[Carsten Book [:Tomcat]]

removing the b2g 2.5 flag since this commit has been reverted due to an incorrect merge, sorry for the confusion