1218694 - Return the AudioNode connected to when calling AudioNode.connect()

Status: RESOLVED FIXED

(Core :: Web Audio, defect)

Description

[Paul Adenot (:padenot)]

https://github.com/WebAudio/web-audio-api/commit/44ebce6044882da08c41f30a835b3564c922a407 and https://github.com/WebAudio/web-audio-api/commit/938cf2bf8f81a4febb0228eae03c9d0af5103cbc

Comment 1

[Paul Adenot (:padenot)]

Attachment: Return the AudioNode connected to when calling AudioNode.connect(). r=

I'd ask Ehsan, but he does not accept review currently, and this is not very
complicated Web Audio-wise.

Comment 2

[Paul Adenot (:padenot)]

Attachment: Test that AudioNode.connect() returns the node connected to. r=

And a web platform test.

Comment 3

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8679297 [details] [diff] [review]
Test that AudioNode.connect() returns the node connected to. r=

Could you test also the case when g2 is already connected to g1.


So, 
add 
assert_equals(g1.connect(g2), g2);

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/2d30c37353ea
https://hg.mozilla.org/integration/mozilla-inbound/rev/95b404586f1d

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/2d30c37353ea
https://hg.mozilla.org/mozilla-central/rev/95b404586f1d