Closed Bug 1218694 Opened 4 years ago Closed 4 years ago

Return the AudioNode connected to when calling AudioNode.connect()

Categories

(Core :: Web Audio, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla44
Tracking Status
firefox44 --- fixed

People

(Reporter: padenot, Assigned: padenot)

Details

Attachments

(2 files)

I'd ask Ehsan, but he does not accept review currently, and this is not very
complicated Web Audio-wise.
Attachment #8679296 - Flags: review?(bugs)
Assignee: nobody → padenot
Status: NEW → ASSIGNED
And a web platform test.
Attachment #8679297 - Flags: review?(bugs)
Attachment #8679296 - Flags: review?(bugs) → review+
Comment on attachment 8679297 [details] [diff] [review]
Test that AudioNode.connect() returns the node connected to. r=

Could you test also the case when g2 is already connected to g1.


So, 
add 
assert_equals(g1.connect(g2), g2);
Attachment #8679297 - Flags: review?(bugs) → review+
https://hg.mozilla.org/mozilla-central/rev/2d30c37353ea
https://hg.mozilla.org/mozilla-central/rev/95b404586f1d
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla44
You need to log in before you can comment on or make changes to this bug.