1218825 - Perfherder graphs view doesn't allow arbitrary zooming

Status: RESOLVED FIXED

(Tree Management :: Perfherder, defect)

Description

[Kartikaya Gupta (email:[e-mail])]

See for example [1]. There are a large number of data points clustered close together and it's hard to identify the exact changeset where the regression happened. If you use graphs.m.o you have the ability to manually draw a box on the graph and zoom in, which allows you to zoom in and display something like [2] from which it's much easier to identify the regressing changeset. Perfherder should support this feature. Being able to look at the graph without actually being able to dig into the data makes the graph much less useful.

(This is a real-world example from bug 1218779 comment 5)

[1] https://treeherder.mozilla.org/perf.html#/graphs?timerange=1209600&series=[mozilla-inbound,fdad6ae27544b0dd52113fce3184968100190e76,1
[2] http://graphs.mozilla.org/graph.html#tests=[[201,63,29]]&sel=1445797128356.3076,1445856279125.5386,0.40095490885805063,15.10262555324946&displayrange=7&datatype=geo

Comment 1

[William Lachance (:wlach)]

You can actually select a region on the small graph above and zoom in there. Is that sufficient for your purposes? If so, maybe we just need to make that feature more discoverable.

Comment 2

[Kartikaya Gupta (email:[e-mail])]

Ah - yeah that seems to be sufficient. It's not as nice because you can't progressively refine the zoom as easily, you have to keep trying on the small graph until you get exactly what you want. But certainly making it more discoverable would be nice, thanks!

Comment 3

[William Lachance (:wlach)]

On second thought, it probably wouldn't be that hard to make the main graph zoomable. If it would be helpful, we should just do it.

Comment 4

[MikeLing]

Attachment: PR for bug 1218825

Not sure if it's an appropriate way to do it. Please tell me if there are anything need to address :)

Comment 5

[William Lachance (:wlach)]

Comment on attachment 8681731 [details] [review]
PR for bug 1218825

This is awesome, thanks :MikeLing! Just a few comments, see PR for details.

Comment 6

[MikeLing]

Comment on attachment 8681731 [details] [review]
PR for bug 1218825

Done! but one thing must be point out is the pointer still the same even I add 'crosshair' to #graph css selector.

Comment 7

[Treeherder GitHub Bugbot]

Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/b45b557a9c1671dfa336c9dba32f146dbc2290e1
Bug 1218825 - Make perfherder main graphs zoomable

Comment 8

[William Lachance (:wlach)]

Comment on attachment 8681731 [details] [review]
PR for bug 1218825

Yeah, the .css method needed to be updated to get the crosshair. I updated the commit to include that change (https://github.com/mozilla/treeherder/commit/b45b557a9c1671dfa336c9dba32f146dbc2290e1#diff-30e3c5e057bc86a56c89530b58b3be63R400) and everything looks good. Thanks!

Comment 9

[Treeherder GitHub Bugbot]

Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/605acbe264497fe29febe556419360cd181e946a
Bug 1218825 - Make zooming from main plot always work

It would fail the first time before.

Comment 10

[Treeherder GitHub Bugbot]

Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/91330dfd7adb1ef94eb9b4044ba7ac5fd535aa75
Bug 1218825 - Fix minor nit